refactor(autoware_launch/bpp-avoidance): remove redundant parameters #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
mehmetdogru
deleted the
refactor/autoware_launch/bpp-avoidance/remove-redundant-params
branch
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
Jan 26, 2023
* update parameter (autowarefoundation#169) * Port pure pursuit (autowarefoundation#166) * Fix control.launch.py * Apply pre-commit * Fix control.launch.py * Change debug topic name in rviz setting * fix typo in localization util.launch.py (autowarefoundation#168) * Feature/add covarinace param (autowarefoundation#170) * add covariance param * add description * remove unused param (autowarefoundation#172) * Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (autowarefoundation#174) * Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0 Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update spell_check_pr.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: fix hdd_monitor param (autowarefoundation#173) * add rosbridge launch (autowarefoundation#175) * add rosbridge launch * fix TODO document add link to pull request Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix double-byte character Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (autowarefoundation#177) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * ci: update CI settings (autowarefoundation#176) * ci(pre-commit): update .pre-commit-config.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci: add sync-files.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: remove old workflows Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci(sync-upstream): update sync-upstream.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci(pre-commit): autofix * style: fix for yamllint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: minor update CI settings (autowarefoundation#179) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [pre-commit.ci] pre-commit autoupdate (autowarefoundation#178) updates: - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0) - [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1) - [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1) - [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: fix CI settings (autowarefoundation#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: sync files (autowarefoundation#180) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (autowarefoundation#184) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: add paricle param (autowarefoundation#181) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (autowarefoundation#185) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update sync-files.yaml Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (autowarefoundation#186) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync system config (autowarefoundation#187) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: sync files (autowarefoundation#189) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> * chore: replace system config in system launch (autowarefoundation#188) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * feat: adds additional configuration flags for behavior_path_planner (autowarefoundation#171) * feat: adds additional configuration flags for behavior_path_planner The additional configuration is used to allows avoidance over lane with same and different direction, as well as allows safety margin between linestring and ego. This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496 port. Related PR: autowarefoundation/autoware.universe#285 autowarefoundation/autoware.universe#287 Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Change lateral_collision_margion to 1.0 to reflect changes. The decision to change the parameter value to 1.0 is made after performing drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting between planning control team on 3rd of February 2022. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: slightly increase the safety buffer. This increases the shift length to 1.7 + 0.5 * vehicle width. The decision to increase is based on the discussion between planning team and also the advice from the FI team. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(behavior_velocity): add path marker visualization (autowarefoundation#190) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: sync files (autowarefoundation#193) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (autowarefoundation#194) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * chore: update workflow files name Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> * chore: sync files (autowarefoundation#195) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> * feat: lateral controller param (autowarefoundation#191) * feat: define lat_controller_param_path * feat: change for trajectory_follower params * add args for lat_controller_param_path * chore: fix wrong essential param to optional (autowarefoundation#197) * fix wrong param line * move pointcloud_container_name param to optional * fix: typo extra `>` (autowarefoundation#199) * Chore arrange perception rviz topics (autowarefoundation#196) * feat(autoware_launch): add occupancy grid vizualization Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(autoware_launch): add object recognition namespace to rviz Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: delete unused in control_launch (autowarefoundation#200) * fix: delete unused in control.launch.py * fix: delete velocity_controller.param.yaml * feat: add system_monitor parameters in sync-files (autowarefoundation#201) * chore: sync files (autowarefoundation#202) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> * chore: sync files (autowarefoundation#203) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: update settings of sync-files (autowarefoundation#204) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat(control_launch): remove unnecessary params (autowarefoundation#206) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (autowarefoundation#208) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat(atutoware.rviz): disable selectable for pointcloud visualization (autowarefoundation#207) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (autowarefoundation#212) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * delete vehicle parameters in longitudinal_controller.param.yaml * apply pre-commit * remove unused file * update sync-param-files.yaml * disable local_external_control in system_error_montitor_psim Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Jun 26, 2023
chore: sync awf/autoware_launch
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Oct 31, 2023
* ci: add build CI Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: add files for Ansible Galaxy Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: copy ansible files from tier4's proposal Remove cache_valid_time Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> v0.4.0 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> copy setup Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> add ros2 ansible roles Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> ansible add ubuntu20 setup Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> ansible fix pacmod Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> temp disable cuda & tensorrt Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> ansible fix kvaser library repo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> temporally comment out for unused modules Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> remove unused codes Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Install osqp only once (autowarefoundation#95) * update readme and fix osqp_vendor tag * Remove ansible osqp role fix: ansbile role Closes autowarefoundation#140 add ansible for cuda 11.1 & tensorrt 7.2.1 & cudnn 8.0.5 Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> add script for install livox sdk Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> add ansible sdk task Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> Use Livox vendor package (autowarefoundation#156) * Use Livox vendor package * Removed Livox SDK from ansible * Use upstream Livox ROS2 driver Install kvaser library Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Update ansible/localhost-setup-ubuntu20.04-devpc.yml Install kvaser library from origin Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Update ansible/localhost-setup-ubuntu20.04-devpc.yml install vcstool and do vcs import in ansible setup (autowarefoundation#170) Update documents and fix typos * update install instructions * remove redundant statements * fix typos Separate Ansible tasks related to vcs import to new role (autowarefoundation#180) * Separate Ansible tasks related to vcs import to new role * Move the Ansible task to install vcstool to the ROS2 role Add rmw-cyclonedds-cpp to ansible (autowarefoundation#67) * Add rmw-cyclonedds-cpp to ansible Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add settings to .bashrc Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Fix setup script typos (autowarefoundation#202) (autowarefoundation#73) Signed-off-by: Lalith Vipulananthan <63835446+LalithVipulananthan@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Revive pacmod role (autowarefoundation#103) * Revert "Install kvaser library from origin" This reverts commit 3859fffd60164febbaacc2f68b045d3b0d07f3d6. Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ROS role Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> install pip before rosdep (autowarefoundation#72) Fix: Update GPG key download task for ROS2 (autowarefoundation#125) * Fix: Update GPG key download task for ROS2 * Fix: Update comments, source list Add pre-commit CI (autowarefoundation#167) * Add pre-commit CI Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add .prettierrc.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore some markdownlint rules Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Move to ROS2 Galactic (autowarefoundation#107) * Fix rosdistro in ansible Fix rosdistro other than autoware in ansible (autowarefoundation#146) * Use upstream grid_map Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove rosbag2 Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Change position of ecu_system_setup section Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing_packages in galactic Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add ros2/rosbag2 galactic to repos Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Purge installed rosbag2 to build it from source Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Add TODO comment to repos Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> Install ros-galactic-ros2cli-common-extensions in ansible (autowarefoundation#183) * Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Install ros-galactic-ros2cli-common-extensions in ansible Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Add descriptions of rosbag2 purge Use apt installed rosbag2 (autowarefoundation#189) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Remove vcs import in ansible (autowarefoundation#198) * Remove vcs import in ansible Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update installation steps Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> fix gdown install command (autowarefoundation#214) Simplify ansible files (autowarefoundation#122) * Simplify ansible files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add build-pr.yml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> add libtorch (autowarefoundation#131) (autowarefoundation#191) * add libtorch (autowarefoundation#131) * add libtorch * update libtorch 1.6.0 -> 1.8.1 * libtorch for CUDA 11.1 * use the same command * libtorch 1.8.1 -> 1.6.0 * add LibTorch for CUDA 11.1 * change install order * Deprecate 18.04 support for libtorch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * pre-commit fixes Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> fix libtorch install (autowarefoundation#196) Feature/remove pacmod3 (autowarefoundation#349) * remove pacmod3 * Remove kvaser_interface from repos Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix ansible Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix vcs import action Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Run pre-commit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> add go dependency for pre-commit (autowarefoundation#388) * add go dependency by snap install --classic * move install-go from autoware/ to pre-commit/ * update playbook.yml * use apt without snap to install golang * chore: clean up files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix: specify pip3 executable to prevent pipx to be used Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: add docker role Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix: use ansible_user_id instead of ansible_env.USER root user doesn't have ansible_env.USER. Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: fix verbose option Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: remove libtorch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: add --no-nvidia option Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * style: rename ansible_options to ansible_args Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: update CUDA versions Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: fix scripts around sudo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: support arm64-sbsa in CUDA role Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci: add ARM build Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: comment out simulator repositories autowarefoundation/autoware#21 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
Description
Remove redundant parameters from bpp-avoidance config file regarding:
https://github.com/orgs/autowarefoundation/discussions/3207#discussioncomment-4704021
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.