Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): common test functions #9963

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 19, 2025

Description

In the same way as behavior_velocity_planner, this PR defined common test functions in behavior_path_planner, and behavior_path_xxx_modules will refer to it to decrease the redundant code.

Related links

How was this PR tested?

Unit test passed.

Notes for reviewers

None.

Interface changes

Only the changes to the unit test

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 19, 2025
Copy link

github-actions bot commented Jan 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the refactor/common-test-impl-in-behavior-path branch from 65c9d1f to 57a7e34 Compare January 19, 2025 08:37
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2025
@takayuki5168 takayuki5168 force-pushed the refactor/common-test-impl-in-behavior-path branch from 57a7e34 to e417a66 Compare January 19, 2025 08:41
@takayuki5168 takayuki5168 marked this pull request as ready for review January 19, 2025 08:42
@takayuki5168 takayuki5168 force-pushed the refactor/common-test-impl-in-behavior-path branch from 4bfec48 to 2ce4fc1 Compare January 19, 2025 08:53
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.44%. Comparing base (4b16661) to head (c033ba8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9963      +/-   ##
==========================================
+ Coverage   29.15%   29.44%   +0.28%     
==========================================
  Files        1423     1425       +2     
  Lines      107814   107864      +50     
  Branches    42234    42818     +584     
==========================================
+ Hits        31437    31761     +324     
+ Misses      73331    73041     -290     
- Partials     3046     3062      +16     
Flag Coverage Δ *Carryforward flag
differential 25.73% <100.00%> (?)
total 29.15% <ø> (ø) Carriedforward from 4b16661

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 37fc242 into autowarefoundation:main Jan 19, 2025
34 checks passed
@takayuki5168 takayuki5168 deleted the refactor/common-test-impl-in-behavior-path branch January 19, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants