Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planner): collision check #985

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 29, 2022

Description

fix #662

Related links

#662

Tests performed

I haven't reproduced this bug so not tested.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 requested a review from TakaHoribe May 29, 2022 05:27
@kosuke55
Copy link
Contributor Author

@TakaHoribe
I can't set @HiroIshida as a reviewer, so please review it.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #985 (6771510) into main (3f25602) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   10.37%   10.39%   +0.02%     
==========================================
  Files        1136     1136              
  Lines       79480    79501      +21     
  Branches    18483    18492       +9     
==========================================
+ Hits         8245     8265      +20     
  Misses      63032    63032              
- Partials     8203     8204       +1     
Flag Coverage Δ *Carryforward flag
differential 47.57% <100.00%> (?)
total 10.35% <100.00%> (ø) Carriedforward from 3f25602

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ace_planning_algorithms/src/abstract_algorithm.cpp 76.53% <100.00%> (-1.40%) ⬇️
.../freespace_planning_algorithms/src/reeds_shepp.cpp 56.89% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f25602...6771510. Read the comment docs.

@xmfcx
Copy link
Contributor

xmfcx commented Jul 19, 2022

@kosuke55 do you know if this PR would fix this issue:

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jul 19, 2022

@xmfcx
I have not checked it but maybe NO. This PR only slightly changed collision check range, so that probably won't fix the issue.

@xmfcx xmfcx requested a review from brkay54 July 26, 2022 16:59
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, I think you are right, in current implementation boundaries of the vehicle may not be added to coll_indexes_table_ exactly. Your implementation should solve this issue. Code is also well, I approved.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55
Copy link
Contributor Author

kosuke55 commented Aug 3, 2022

@brkay54
thank you for your review!

@kosuke55 kosuke55 merged commit 4d10180 into autowarefoundation:main Aug 3, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(freespace_planner): collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Exact collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(freespace_planner): collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Exact collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(freespace_planner): collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Exact collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* fix(freespace_planner): collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Exact collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(freespace_planner): collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Exact collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
YoshiRi added a commit to YoshiRi/autoware.universe that referenced this pull request Oct 30, 2023
…er for ars408 in xx1 (autowarefoundation#985)

change radar obj clustering angle threshold to loose coupling
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Improved tpe

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

free space planner may collide obstacles with vehicle front
3 participants