-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(freespace_planner): collision check #985
Conversation
@TakaHoribe |
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 10.37% 10.39% +0.02%
==========================================
Files 1136 1136
Lines 79480 79501 +21
Branches 18483 18492 +9
==========================================
+ Hits 8245 8265 +20
Misses 63032 63032
- Partials 8203 8204 +1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
@kosuke55 do you know if this PR would fix this issue: |
@xmfcx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, I think you are right, in current implementation boundaries of the vehicle may not be added to coll_indexes_table_
exactly. Your implementation should solve this issue. Code is also well, I approved.
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@brkay54 |
* fix(freespace_planner): collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Exact collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* fix(freespace_planner): collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Exact collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* fix(freespace_planner): collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Exact collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* fix(freespace_planner): collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Exact collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* fix(freespace_planner): collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Exact collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…er for ars408 in xx1 (autowarefoundation#985) change radar obj clustering angle threshold to loose coupling
Improved tpe Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Description
fix #662
Related links
#662
Tests performed
I haven't reproduced this bug so not tested.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.