Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(autoware_lidar_centerpoint): process front voxels first #9792

Conversation

technolojin
Copy link
Contributor

Description

revert "feat(autoware_lidar_centerpoint): process front voxels first ……(#9608)"

This reverts commit 91984f8.

Revert since it had illegal memory access as following

[component_container_mt-1] [WARN] [1735120020.355710921] [sensing.lidar.concatenate_data]: transformed_raw_points[/sensing/lidar/top/pointcloud_before_sync] is nullptr, skipping pointcloud publish.
[component_container_mt-1] terminate called after throwing an instance of 'thrust::system::system_error'
[component_container_mt-1]   what():  parallel_for: failed to synchronize: cudaErrorIllegalAddress: an illegal memory access was encountered
[component_container_mt-1] *** Aborted at 1735120027 (unix time) try "date -d @1735120027" if you are using GNU date ***
[component_container_mt-1] PC: @                0x0 (unknown)
[component_container_mt-1] *** SIGABRT (@0x3e800028313) received by PID 164627 (TID 0x7fcd397fa640) from PID 164627; stack trace: ***
[component_container_mt-1]     @     0x7fcd64a244d6 google::(anonymous namespace)::FailureSignalHandler()
[component_container_mt-1]     @     0x7fcd642cd520 (unknown)
[component_container_mt-1]     @     0x7fcd643219fc pthread_kill
[component_container_mt-1]     @     0x7fcd642cd476 raise
[component_container_mt-1]     @     0x7fcd642b37f3 abort
[component_container_mt-1]     @     0x7fcd64578b9e (unknown)
[component_container_mt-1]     @     0x7fcd6458420c (unknown)
[component_container_mt-1]     @     0x7fcd64584277 std::terminate()
[component_container_mt-1]     @     0x7fcd645844d8 __cxa_throw
[component_container_mt-1]     @     0x7fcc79f13f4c thrust::detail::vector_base<>::vector_base()
[component_container_mt-1]     @     0x7fcc79f10243 autoware::lidar_centerpoint::PostProcessCUDA::generateDetectedBoxes3D_launch()
[component_container_mt-1]     @     0x7fcc7a0615db autoware::lidar_centerpoint::CenterPointTRT::postProcess()
[component_container_mt-1]     @     0x7fcc7a065db3 autoware::lidar_centerpoint::CenterPointTRT::detect()
[component_container_mt-1]     @     0x7fcc7a1dcdef autoware::lidar_centerpoint::LidarCenterPointNode::pointCloudCallback()
[component_container_mt-1]     @     0x7fcc7a1ef2e8 std::_Function_handler<>::_M_invoke()
[component_container_mt-1]     @     0x7fcd585a1fc7 _ZNSt8__detail9__variant17__gen_vtable_implINS0_12_Multi_arrayIPFNS0_21__deduce_visit_resultIvEEOZN6rclcpp23AnySubscriptionCallbackIN11sensor_msgs3msg12PointCloud2_ISaIvEEESA_E8dispatchESt10shared_ptrISB_ERKNS5_11MessageInfoEEUlOT_E_RSt7variantIJSt8functionIFvRKSB_EESN_IFvSP_SH_EESN_IFvRKNS5_17SerializedMessageEEESN_IFvSW_SH_EESN_IFvSt10unique_ptrISB_St14default_deleteISB_EEEESN_IFvS14_SH_EESN_IFvS11_ISU_S12_ISU_EEEESN_IFvS1A_SH_EESN_IFvSD_ISO_EEESN_IFvS1F_SH_EESN_IFvSD_ISV_EEESN_IFvS1K_SH_EESN_IFvRKS1F_EESN_IFvS1Q_SH_EESN_IFvRKS1K_EESN_IFvS1W_SH_EESN_IFvSE_EESN_IFvSE_SH_EESN_IFvSD_ISU_EEESN_IFvS25_SH_EEEEEJEEESt16integer_sequenceImJLm8EEEE14__visit_invokeESL_S2B_
[component_container_mt-1]     @     0x7fcc7a20a145 rclcpp::Subscription<>::handle_message()
[component_container_mt-1]     @     0x7fcd648a0ba0 rclcpp::Executor::execute_subscription()
[component_container_mt-1]     @     0x7fcd648a210e rclcpp::Executor::execute_any_executable()
[component_container_mt-1]     @     0x7fcd648a8432 rclcpp::executors::MultiThreadedExecutor::run()
[component_container_mt-1]     @     0x7fcd645b2253 (unknown)
[component_container_mt-1]     @     0x7fcd6431fac3 (unknown)
[component_container_mt-1]     @     0x7fcd643b1850 (unknown)

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…utowarefoundation#9608)"

This reverts commit 91984f8.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin self-assigned this Dec 26, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review December 26, 2024 00:39
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.08%. Comparing base (1586372) to head (c5d4f4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9792      +/-   ##
==========================================
- Coverage   30.08%   30.08%   -0.01%     
==========================================
  Files        1450     1451       +1     
  Lines      108852   108867      +15     
  Branches    42743    42746       +3     
==========================================
+ Hits        32752    32756       +4     
- Misses      72898    72909      +11     
  Partials     3202     3202              
Flag Coverage Δ *Carryforward flag
differential 3.48% <ø> (?)
differential-cuda 6.01% <ø> (?)
total 30.08% <ø> (ø) Carriedforward from 1586372

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor Author

a solution has been found. close the revert pr

@technolojin technolojin deleted the revert/centerpoint/process-voxel-order branch December 26, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants