-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_lidar_centerpoint): process front voxels first #9608
feat(autoware_lidar_centerpoint): process front voxels first #9608
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
c5b01a2
to
167b69d
Compare
perception/autoware_lidar_centerpoint/lib/preprocess/preprocess_kernel.cu
Show resolved
Hide resolved
Would you also locally check if the unit test passes? Currently it's disabled due to the issue in GitHub Action runner if I recall correctly. autoware.universe/perception/autoware_lidar_centerpoint/CMakeLists.txt Lines 164 to 207 in 3cfb03e
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would also be better to get a review from Kenzo-san as I am not that familiar with CUDA programming, but overall looks good to me.
perception/autoware_lidar_centerpoint/lib/preprocess/preprocess_kernel.cu
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay
…utowarefoundation#9608)" This reverts commit 91984f8. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
Alternative solution of PR #9583
Related links
Parent Issue:
How was this PR tested?
The following visualization is to show filled voxel distribution. Configurations are as follwing.
Then lower score object will be shown (due to the lower score_threshold), indirectly visualize where the voxel is filled.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.