Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_lidar_centerpoint): process front voxels first #9608

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Dec 10, 2024

Description

Alternative solution of PR #9583

  1. exchange x and y to process in a row-major order
  2. flip x axis direction to process front to back

Related links

Parent Issue:

  • Link

How was this PR tested?

The following visualization is to show filled voxel distribution. Configurations are as follwing.

  • input high-density lidar point cloud
  • score_threshold: 0.01
  • max_voxel_size: 40000
  • point_cloud_range: [-121.6, -76.8, -3.0, 121.6, 76.8, 5.0]

Then lower score object will be shown (due to the lower score_threshold), indirectly visualize where the voxel is filled.

Screenshot from 2024-12-10 17-55-50

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the feat/centerpoint/voxel-fill-from-front2 branch from c5b01a2 to 167b69d Compare December 11, 2024 08:58
@technolojin technolojin marked this pull request as ready for review December 11, 2024 09:17
@kminoda
Copy link
Contributor

kminoda commented Dec 12, 2024

Would you also locally check if the unit test passes? Currently it's disabled due to the issue in GitHub Action runner if I recall correctly.

# https://github.com/autowarefoundation/autoware.universe/issues/7724
# ament_auto_add_gtest(test_voxel_generator
# test/test_voxel_generator.cpp
# )
#
# add_executable(test_preprocess_kernel
# test/test_preprocess_kernel.cpp
# lib/utils.cpp
# )
#
# target_include_directories(test_preprocess_kernel PUBLIC
# ${test_preprocess_kernel_SOURCE_DIR}
# )
#
# target_link_libraries(test_preprocess_kernel
# ${PROJECT_NAME}_cuda_lib
# gtest
# gtest_main
# )
#
# ament_add_test(test_preprocess_kernel
# GENERATE_RESULT_FOR_RETURN_CODE_ZERO
# COMMAND "$<TARGET_FILE:test_preprocess_kernel>"
# )
#
# add_executable(test_postprocess_kernel
# test/test_postprocess_kernel.cpp
# lib/utils.cpp
# )
#
# target_include_directories(test_postprocess_kernel PUBLIC
# ${test_postprocess_kernel_SOURCE_DIR}
# )
#
# target_link_libraries(test_postprocess_kernel
# ${PROJECT_NAME}_cuda_lib
# gtest
# gtest_main
# )
#
# ament_add_test(test_postprocess_kernel
# GENERATE_RESULT_FOR_RETURN_CODE_ZERO
# COMMAND "$<TARGET_FILE:test_postprocess_kernel>"
# )

@technolojin
Copy link
Contributor Author

Would you also locally check if the unit test passes? Currently it's disabled due to the issue in GitHub Action runner if I recall correctly.

# https://github.com/autowarefoundation/autoware.universe/issues/7724
# ament_auto_add_gtest(test_voxel_generator
# test/test_voxel_generator.cpp
# )
#
# add_executable(test_preprocess_kernel
# test/test_preprocess_kernel.cpp
# lib/utils.cpp
# )
#
# target_include_directories(test_preprocess_kernel PUBLIC
# ${test_preprocess_kernel_SOURCE_DIR}
# )
#
# target_link_libraries(test_preprocess_kernel
# ${PROJECT_NAME}_cuda_lib
# gtest
# gtest_main
# )
#
# ament_add_test(test_preprocess_kernel
# GENERATE_RESULT_FOR_RETURN_CODE_ZERO
# COMMAND "$<TARGET_FILE:test_preprocess_kernel>"
# )
#
# add_executable(test_postprocess_kernel
# test/test_postprocess_kernel.cpp
# lib/utils.cpp
# )
#
# target_include_directories(test_postprocess_kernel PUBLIC
# ${test_postprocess_kernel_SOURCE_DIR}
# )
#
# target_link_libraries(test_postprocess_kernel
# ${PROJECT_NAME}_cuda_lib
# gtest
# gtest_main
# )
#
# ament_add_test(test_postprocess_kernel
# GENERATE_RESULT_FOR_RETURN_CODE_ZERO
# COMMAND "$<TARGET_FILE:test_postprocess_kernel>"
# )

colcon test --packages-select autoware_lidar_centerpoint
Starting >>> autoware_lidar_centerpoint
Finished <<< autoware_lidar_centerpoint [3.13s]          

Summary: 1 package finished [4.41s]

@technolojin technolojin requested a review from kminoda December 12, 2024 03:06
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would also be better to get a review from Kenzo-san as I am not that familiar with CUDA programming, but overall looks good to me.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay

@technolojin technolojin merged commit 91984f8 into autowarefoundation:main Dec 16, 2024
26 of 27 checks passed
@technolojin technolojin deleted the feat/centerpoint/voxel-fill-from-front2 branch December 16, 2024 00:05
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Dec 26, 2024
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Dec 26, 2024
…utowarefoundation#9608)"

This reverts commit 91984f8.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants