Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_multi_object_tracker): fix clang-diagnostic-unused-private-field #9491

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-unused-private-field error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_multi_object_tracker/src/debugger/debug_object.hpp:80:11: error: private field 'marker_id_' is not used [clang-diagnostic-unused-private-field]
  int32_t marker_id_ = 0;
          ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_multi_object_tracker/src/processor/input_manager.hpp:91:10: error: private field 'expected_interval_' is not used [clang-diagnostic-unused-private-field]
  double expected_interval_{};
         ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_multi_object_tracker/src/processor/input_manager.hpp:133:10: error: private field 'target_latency_' is not used [clang-diagnostic-unused-private-field]
  double target_latency_{0.2};               // [s]
         ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_multi_object_tracker/src/processor/input_manager.hpp:134:10: error: private field 'target_latency_band_' is not used [clang-diagnostic-unused-private-field]
  double target_latency_band_{1.0};          // [s]
         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc November 27, 2024 10:08
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (85d5bc4) to head (25ddd89).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9491      +/-   ##
==========================================
+ Coverage   29.52%   29.54%   +0.01%     
==========================================
  Files        1439     1439              
  Lines      108510   108516       +6     
  Branches    41504    41507       +3     
==========================================
+ Hits        32035    32058      +23     
+ Misses      73355    73337      -18     
- Partials     3120     3121       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.54% <ø> (+0.02%) ⬆️ Carriedforward from 24ef1f9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin self-assigned this Nov 28, 2024
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 4e93960 into autowarefoundation:main Nov 28, 2024
42 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-pe5 branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants