Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_lane_change_module): fix clang-diagnostic-unused-variable #9401

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-unused-variable error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp:952:16: error: unused variable 'route_handler' [clang-diagnostic-unused-variable]
  const auto & route_handler = getRouteHandler();
               ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp:1065:16: error: unused variable 'route_handler' [clang-diagnostic-unused-variable]
  const auto & route_handler = getRouteHandler();
               ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp:1224:16: error: unused variable 'route_handler' [clang-diagnostic-unused-variable]
  const auto & route_handler = getRouteHandler();
               ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 20, 2024
@veqcc
Copy link
Contributor

veqcc commented Nov 26, 2024

@mkquda @rej55 @kosuke55 @maxime-clem @satoshi-ota @shmpwk @TomohitoAndo @tkimura4 @zulfaqar-azmi-t4
Hi

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not main maintainer but seems ok

@veqcc
Copy link
Contributor

veqcc commented Nov 27, 2024

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.52%. Comparing base (4e93960) to head (ea87aab).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9401      +/-   ##
==========================================
+ Coverage   29.51%   29.52%   +0.01%     
==========================================
  Files        1440     1441       +1     
  Lines      108541   108566      +25     
  Branches    41507    41506       -1     
==========================================
+ Hits        32034    32055      +21     
- Misses      73388    73393       +5     
+ Partials     3119     3118       -1     
Flag Coverage Δ *Carryforward flag
differential 22.38% <ø> (?)
total 29.53% <ø> (+0.01%) ⬆️ Carriedforward from 2fbacc7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 1e37266 into autowarefoundation:main Nov 28, 2024
32 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-p8 branch December 9, 2024 01:24
zulfaqar-azmi-t4 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…unused-variable (autowarefoundation#9401)

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…unused-variable (autowarefoundation#9401)

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…unused-variable (autowarefoundation#9401)

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants