Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): reduce prepare duration when blinker has been activated #9185

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Oct 30, 2024

Description

Currently, a constant prepare duration (parameterized) is being used when generating LC path candidates, this was necessary because until recently turn signal was activated only after LC path was approved.

However, LC turn signal logic was recently changed to activate as soon as we have the intention to change lanes (i.e: when LC module is run). Therefore it is no longer necessary to have a constant long prepare duration, and we can reduce the prepare duration as the turn signal on duration increases.

Changes

  • Add member variable signal_activation_time_ to LaneChangeBase class
  • Add member variable lane_change_prepare_duration to TransientData struct
  • Add function calc_actual_prepare_duration to calculate actual needed prepare duration based on current velocity and signal on duration
  • Modify function update_transient_data to set lane_change_prepare_duration

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added min_prepare_duration double 1.0 Minimum preparation time for the ego vehicle to be ready to perform lane change
Added lane_changing_decel_factor double 0.5 longitudinal deceleration factor during lane changing phase

Modifications

Version Parameter Name Type Default Value Description
Old prepare_duration double 4.0 Preparation time for the ego vehicle to be ready to perform lane change
New max_prepare_duration double 4.0 Maximum preparation time for the ego vehicle to be ready to perform lane change

Effects on system behavior

When LC module activates, initially prepare duration will be max, as signal activation duration increases, prepare duration will be gradually reduced to minimum, allowing a shorter LC path to be found.

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

mkquda and others added 10 commits October 31, 2024 09:46
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
…owarefoundation#9173)

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* add requested feature

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* Update planning/autoware_rtc_interface/test/test_rtc_interface.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…ws (autowarefoundation#9199)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
fix(bpp): calcDistanceToRedTrafficLight null

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
… predictor (autowarefoundation#9201)

* refactor: grouping functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: grouping parameters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename member road_users_history to road_users_history_

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: separate util functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add predictor_vru.cpp and utils.cpp to map_based_prediction_node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add explicit template instantiation for removeOldObjectsHistory function

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add tf2_geometry_msgs to data_structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Remove unused variables and functions in map_based_prediction_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Update perception/autoware_map_based_prediction/include/map_based_prediction/predictor_vru.hpp

* Apply suggestions from code review

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…er (autowarefoundation#8912)

* Moved ndt_omp into ndt_scan_matcher

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added Copyright

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed cast style

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed NVTP to NVTL

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added cspell:ignore

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed miss spell

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Renamed applyFilter

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Moved ***_impl.hpp from include/ to src/

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed variable scope

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed to pass by reference

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Oct 31, 2024
…transient data

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
mkquda and others added 2 commits December 3, 2024 15:48
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…nge_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mkquda and others added 12 commits December 4, 2024 17:34
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…ion' into RT1-8204-reduce-prepare-duration-when-blinker-has-been-activated

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…ion' into RT1-8204-reduce-prepare-duration-when-blinker-has-been-activated
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…nge_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…ion' into RT1-8204-reduce-prepare-duration-when-blinker-has-been-activated
@mkquda mkquda merged commit 0992f1d into autowarefoundation:main Dec 5, 2024
32 of 33 checks passed
@mkquda mkquda deleted the RT1-8204-reduce-prepare-duration-when-blinker-has-been-activated branch December 5, 2024 00:05
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…vated (autowarefoundation#9185)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* reduce prepare duration according to signal activation time

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: update CODEOWNERS (autowarefoundation#9203)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* refactor(time_utils): prefix package and namespace with autoware (autowarefoundation#9173)

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(rtc_interface): add requested field (autowarefoundation#9202)

* add requested feature

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* Update planning/autoware_rtc_interface/test/test_rtc_interface.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* fix(mpc_lateral_controller): correctly resample the MPC trajectory yaws (autowarefoundation#9199)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(bpp): prevent accessing nullopt (autowarefoundation#9204)

fix(bpp): calcDistanceToRedTrafficLight null

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* refactor(autoware_map_based_prediction): split pedestrian and bicycle predictor (autowarefoundation#9201)

* refactor: grouping functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: grouping parameters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename member road_users_history to road_users_history_

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: separate util functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add predictor_vru.cpp and utils.cpp to map_based_prediction_node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add explicit template instantiation for removeOldObjectsHistory function

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add tf2_geometry_msgs to data_structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Remove unused variables and functions in map_based_prediction_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Update perception/autoware_map_based_prediction/include/map_based_prediction/predictor_vru.hpp

* Apply suggestions from code review

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(ndt_scan_matcher, ndt_omp): move ndt_omp into ndt_scan_matcher (autowarefoundation#8912)

* Moved ndt_omp into ndt_scan_matcher

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added Copyright

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed cast style

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed NVTP to NVTL

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added cspell:ignore

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed miss spell

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Renamed applyFilter

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Moved ***_impl.hpp from include/ to src/

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed variable scope

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed to pass by reference

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_test_utils): add traffic light msgs parser (autowarefoundation#9177)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* modify implementation to compute and keep actual prepare duration in transient data

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* if LC path is approved, set prepare duration in transient data from approved path prepare duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* change default value of LC param min_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* add function to set signal activation time, add docstring for function calc_actual_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* check for zero value max_acc to avoid division by zero

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix units

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

---------

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…vated (autowarefoundation#9185)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* reduce prepare duration according to signal activation time

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: update CODEOWNERS (autowarefoundation#9203)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* refactor(time_utils): prefix package and namespace with autoware (autowarefoundation#9173)

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(rtc_interface): add requested field (autowarefoundation#9202)

* add requested feature

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* Update planning/autoware_rtc_interface/test/test_rtc_interface.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* fix(mpc_lateral_controller): correctly resample the MPC trajectory yaws (autowarefoundation#9199)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(bpp): prevent accessing nullopt (autowarefoundation#9204)

fix(bpp): calcDistanceToRedTrafficLight null

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* refactor(autoware_map_based_prediction): split pedestrian and bicycle predictor (autowarefoundation#9201)

* refactor: grouping functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: grouping parameters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename member road_users_history to road_users_history_

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: separate util functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add predictor_vru.cpp and utils.cpp to map_based_prediction_node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add explicit template instantiation for removeOldObjectsHistory function

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add tf2_geometry_msgs to data_structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Remove unused variables and functions in map_based_prediction_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Update perception/autoware_map_based_prediction/include/map_based_prediction/predictor_vru.hpp

* Apply suggestions from code review

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(ndt_scan_matcher, ndt_omp): move ndt_omp into ndt_scan_matcher (autowarefoundation#8912)

* Moved ndt_omp into ndt_scan_matcher

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added Copyright

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed cast style

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed NVTP to NVTL

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added cspell:ignore

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed miss spell

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Renamed applyFilter

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Moved ***_impl.hpp from include/ to src/

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed variable scope

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed to pass by reference

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_test_utils): add traffic light msgs parser (autowarefoundation#9177)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* modify implementation to compute and keep actual prepare duration in transient data

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* if LC path is approved, set prepare duration in transient data from approved path prepare duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* change default value of LC param min_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* add function to set signal activation time, add docstring for function calc_actual_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* check for zero value max_acc to avoid division by zero

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix units

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

---------

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…vated (autowarefoundation#9185)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* reduce prepare duration according to signal activation time

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: update CODEOWNERS (autowarefoundation#9203)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* refactor(time_utils): prefix package and namespace with autoware (autowarefoundation#9173)

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* refactor(time_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(rtc_interface): add requested field (autowarefoundation#9202)

* add requested feature

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* Update planning/autoware_rtc_interface/test/test_rtc_interface.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* fix(mpc_lateral_controller): correctly resample the MPC trajectory yaws (autowarefoundation#9199)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(bpp): prevent accessing nullopt (autowarefoundation#9204)

fix(bpp): calcDistanceToRedTrafficLight null

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* refactor(autoware_map_based_prediction): split pedestrian and bicycle predictor (autowarefoundation#9201)

* refactor: grouping functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: grouping parameters

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename member road_users_history to road_users_history_

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: separate util functions

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add predictor_vru.cpp and utils.cpp to map_based_prediction_node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add explicit template instantiation for removeOldObjectsHistory function

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Add tf2_geometry_msgs to data_structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: Remove unused variables and functions in map_based_prediction_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Update perception/autoware_map_based_prediction/include/map_based_prediction/predictor_vru.hpp

* Apply suggestions from code review

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(ndt_scan_matcher, ndt_omp): move ndt_omp into ndt_scan_matcher (autowarefoundation#8912)

* Moved ndt_omp into ndt_scan_matcher

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added Copyright

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed cast style

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed honorific title

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed hierarchy

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed NVTP to NVTL

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added cspell:ignore

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed miss spell

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed include

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Renamed applyFilter

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Moved ***_impl.hpp from include/ to src/

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Fixed variable scope

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Fixed to pass by reference

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_test_utils): add traffic light msgs parser (autowarefoundation#9177)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* modify implementation to compute and keep actual prepare duration in transient data

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* if LC path is approved, set prepare duration in transient data from approved path prepare duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* change default value of LC param min_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* add function to set signal activation time, add docstring for function calc_actual_prepare_duration

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* check for zero value max_acc to avoid division by zero

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: rename codeowners file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix units

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* allow decelerating in lane changing phase near terminal

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* Update planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* run pre-commit check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix format

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

---------

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants