feat(lane_change): add new lane change parameter #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
mkquda
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
maxime-clem,
soblin,
yhisaki and
yuki-takagi-66
as code owners
maxime-clem
approved these changes
Nov 13, 2024
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
zulfaqar-azmi-t4
approved these changes
Dec 2, 2024
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Dec 5, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253) Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp> * feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210) feat(object_lanelet_filter): add configurable margin for object lanelet filter Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> * fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257) fix a visulization bug. Signed-off-by: temkei.kem <1041084556@qq.com> * refactor(glog_component): prefix package and namespace with autoware (autowarefoundation#1245) Signed-off-by: Esteve Fernandez <esteve@apache.org> * refactor(global_parameter_loader): prefix package and namespace with autoware (autowarefoundation#1246) Signed-off-by: Esteve Fernandez <esteve@apache.org> * feat(lane_change): add new lane change parameter (autowarefoundation#1224) * add minimum prepare duration parameter Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * increase min_prepare_duration to 1.0 s Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * increase min prepare duration value, add new parameter Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp> Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Signed-off-by: temkei.kem <1041084556@qq.com> Signed-off-by: Esteve Fernandez <esteve@apache.org> Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com> Co-authored-by: Sebastian Zęderowski <sebek.x@gmail.com> Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Co-authored-by: Kem (TiankuiXian) <1041084556@qq.com> Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com> Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new lane change parameter
min_prepare_durationrequired due to following PR.autowarefoundation/autoware.universe#9185
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.