-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): update pull_over module #873
Conversation
Great. I'd like to experiment in test fields before merge. |
0f675dd
to
941986c
Compare
Merge #901 first. |
0238cd0
to
57bd0ba
Compare
a1571a2
to
143f049
Compare
PR is too big. Can you separate this for utils? |
planning/behavior_path_planner/config/pull_over/pull_over.param.yaml
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
========================================
- Coverage 9.50% 9.40% -0.11%
========================================
Files 1095 1097 +2
Lines 75760 76856 +1096
Branches 16463 17425 +962
========================================
+ Hits 7204 7228 +24
- Misses 61961 62924 +963
- Partials 6595 6704 +109
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
8574caa
to
8408da8
Compare
@yukkysaito @tkimura4 |
8408da8
to
ababc5c
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
ababc5c
to
edddea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(behavior_path_planner): update pull_over module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror of humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix goal change bug when starting drive Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(behavior_path_planner): update pull_over module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror of humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix goal change bug when starting drive Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(behavior_path_planner): update pull_over module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror of humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix goal change bug when starting drive Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ion#873) * feat(behavior_path_planner): update pull_over module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror of humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix goal change bug when starting drive Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(behavior_path_planner): update pull_over module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror of humble Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix goal change bug when starting drive Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
Updated pull_over_module. Added the following features
goal_search-2022-06-17_14.01.17.mp4
pull_over_shift-2022-06-22_10.50.46.mp4
pull_over_arc_forward-2022-06-22_10.54.39.mp4
pull_over_back-2022-06-20_12.40.09.1.mp4
pull_over_no_space-2022-06-20_12.37.03.mp4
Related links
Tests performed
psim, scenario test, real vehicle.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.