Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): update pull_over module #873

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 9, 2022

Description

Updated pull_over_module. Added the following features

  • goal search. find free space for parking using occupancy grid.
goal_search-2022-06-17_14.01.17.mp4
  • multiple parking method considering how large is the space
    • shift parking
pull_over_shift-2022-06-22_10.50.46.mp4
  • arc forward parking
pull_over_arc_forward-2022-06-22_10.54.39.mp4
  • arc backward parking
pull_over_back-2022-06-20_12.40.09.1.mp4
  • wait until space in available
pull_over_no_space-2022-06-20_12.37.03.mp4

Related links

Tests performed

psim, scenario test, real vehicle.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 changed the title Feature/pull over feat(behavior_path_planner): update pull_over module May 9, 2022
@yukkysaito
Copy link
Contributor

Great. I'd like to experiment in test fields before merge.

@kosuke55 kosuke55 force-pushed the feature/pull_over branch 2 times, most recently from 0f675dd to 941986c Compare May 16, 2022 10:10
@kosuke55
Copy link
Contributor Author

Merge #901 first.

@kosuke55 kosuke55 force-pushed the feature/pull_over branch 2 times, most recently from 0238cd0 to 57bd0ba Compare May 18, 2022 03:09
@kosuke55 kosuke55 force-pushed the feature/pull_over branch 4 times, most recently from a1571a2 to 143f049 Compare May 31, 2022 10:48
@kosuke55 kosuke55 marked this pull request as ready for review July 6, 2022 03:51
@kosuke55 kosuke55 requested review from tkimura4 and yukkysaito July 6, 2022 03:52
@yukkysaito
Copy link
Contributor

yukkysaito commented Jul 6, 2022

PR is too big. Can you separate this for utils?

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #873 (749f7a0) into main (e228bda) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #873      +/-   ##
========================================
- Coverage   9.50%   9.40%   -0.11%     
========================================
  Files       1095    1097       +2     
  Lines      75760   76856    +1096     
  Branches   16463   17425     +962     
========================================
+ Hits        7204    7228      +24     
- Misses     61961   62924     +963     
- Partials    6595    6704     +109     
Flag Coverage Δ *Carryforward flag
differential 2.99% <0.00%> (?)
total 9.49% <0.00%> (ø) Carriedforward from 80a54ea

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
map/lanelet2_extension/lib/utilities.cpp 10.70% <0.00%> (+1.80%) ⬆️
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <0.00%> (ø)
..._planner/scene_module/pull_over/pull_over_path.hpp 0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.34% <0.00%> (+0.09%) ⬆️
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 1.04% <0.00%> (-0.07%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e228bda...749f7a0. Read the comment docs.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jul 8, 2022

@yukkysaito @tkimura4
All separated PR has been merged so squashed this PR.

@kosuke55 kosuke55 force-pushed the feature/pull_over branch from 8408da8 to ababc5c Compare July 8, 2022 10:47
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/pull_over branch from ababc5c to edddea8 Compare July 8, 2022 10:56
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kosuke55 added 2 commits July 8, 2022 23:12
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit 56885ed into autowarefoundation:main Jul 8, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(behavior_path_planner): update pull_over module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror of humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix test

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix goal change bug when starting drive

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(behavior_path_planner): update pull_over module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror of humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix test

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix goal change bug when starting drive

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(behavior_path_planner): update pull_over module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror of humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix test

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix goal change bug when starting drive

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ion#873)

* feat(behavior_path_planner): update pull_over module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror of humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix test

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix goal change bug when starting drive

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(behavior_path_planner): update pull_over module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use tf2_geometry_msgs/tf2_geometry_msgs.hpp for humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror of humble

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix test

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix goal change bug when starting drive

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants