Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_departure_checker): support path_with_lane_id #1279

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 7, 2022

Description

make lane_departure_checker to support path_with_lane_id.
This enables behavior_path_planner modules to check lane departure.

Related links

This is the part of #873

Tests performed

check path does not deviate from the lane with psim and real vehicle.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review July 7, 2022 17:04
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1279 (78e85f8) into main (dccd042) will decrease coverage by 0.00%.
The diff coverage is 15.68%.

@@           Coverage Diff            @@
##            main   #1279      +/-   ##
========================================
- Coverage   9.72%   9.71%   -0.01%     
========================================
  Files       1073    1073              
  Lines      73996   74034      +38     
  Branches   16304   16304              
========================================
  Hits        7195    7195              
- Misses     60214   60252      +38     
  Partials    6587    6587              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.70% <17.77%> (ø) Carriedforward from dccd042

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
..._departure_checker_node/lane_departure_checker.cpp 0.00% <0.00%> (ø)
...ctory_follower/include/trajectory_follower/mpc.hpp 46.66% <ø> (ø)
...wer/include/trajectory_follower/mpc_trajectory.hpp 0.00% <ø> (ø)
.../include/behavior_path_planner/debug_utilities.hpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/scene_module/lane_change/lane_change_path.hpp 0.00% <ø> (ø)
...th_planner/scene_module/pull_out/pull_out_path.hpp 0.00% <ø> (ø)
..._planner/scene_module/pull_over/pull_over_path.hpp 0.00% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe9420...78e85f8. Read the comment docs.

@kosuke55 kosuke55 requested a review from rej55 July 8, 2022 03:45
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit d3ccde7 into autowarefoundation:main Jul 8, 2022
@rej55 rej55 deleted the feature/path_with_lane_id_lane_departure branch July 8, 2022 06:46
esteve pushed a commit that referenced this pull request Jul 8, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants