Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic_graph_aggregator): fix unusedFunction #8580

Merged

Conversation

bathteayo
Copy link
Member

Description

This is a fix based on cppcheck unusedFunction warnings.

src/common/graph/graph.hpp:37:0: style: The function 'diags' is never used. [unusedFunction]
  const auto & diags() const { return diags_; }
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: bathteayo <105347690+bathteayo@users.noreply.github.com>
@bathteayo bathteayo requested a review from veqcc August 22, 2024 08:23
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@bathteayo bathteayo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.99%. Comparing base (44e0535) to head (771880d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8580      +/-   ##
==========================================
- Coverage   24.02%   23.99%   -0.03%     
==========================================
  Files        1384     1384              
  Lines      102177   102172       -5     
  Branches    38956    38956              
==========================================
- Hits        24544    24520      -24     
- Misses      75138    75179      +41     
+ Partials     2495     2473      -22     
Flag Coverage Δ *Carryforward flag
differential 63.50% <ø> (?)
total 23.99% <ø> (-0.03%) ⬇️ Carriedforward from c5e8062

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit 27bc0a9 into autowarefoundation:main Aug 23, 2024
31 checks passed
@bathteayo bathteayo deleted the fix/cppcheck_unusedFunction_sys-7 branch August 23, 2024 11:33
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…ion#8580)

fix: unusedFunction

Signed-off-by: bathteayo <105347690+bathteayo@users.noreply.github.com>
Co-authored-by: kobayu858 <129580202+kobayu858@users.noreply.github.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…ion#8580)

fix: unusedFunction

Signed-off-by: bathteayo <105347690+bathteayo@users.noreply.github.com>
Co-authored-by: kobayu858 <129580202+kobayu858@users.noreply.github.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…ion#8580)

fix: unusedFunction

Signed-off-by: bathteayo <105347690+bathteayo@users.noreply.github.com>
Co-authored-by: kobayu858 <129580202+kobayu858@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants