fix(lane_change): intersection check caused incorrect stopping point #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added
type:bug
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
========================================
- Coverage 9.55% 9.54% -0.01%
========================================
Files 921 921
Lines 57196 57231 +35
Branches 6830 6830
========================================
Hits 5465 5465
- Misses 47229 47264 +35
Partials 4502 4502
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
…ier4#818) this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#818) this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#818) this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
…ier4#818) this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
deleted the
810-checkLAneIsInIntersection-lane-change-bug
branch
ryuichi-maeda
pushed a commit
to sensefield/autoware.universe
that referenced
this pull request
Jan 10, 2025
) * playbooks.ecu_common: use new otaclient and otaclient_logger roles * ecu_setup.yaml: setup sample setting variables for new otaclient and otaclient_logger roles * add cspell.json, includes otaclient related terms * style(pre-commit): autofix * minor update --------- Co-authored-by: Bodong-Yang <Bodong-Yang@users.noreply.github.com>
iwatake2222
pushed a commit
to iwatake2222/autoware.universe
that referenced
this pull request
Jan 17, 2025
…utowarefoundation#818) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp
Description
this is happens whenever intersection is involved.
If the there is intersection in the list of lanelet sequence, if the goal is not in the intersection, the last stopping point is not within stopping threshold.
Related links
#531
#810
Tests performed
Test 1:
Example 1:
Example 2:
Peek.2022-04-27.14-59.mp4
Test 2:
Example 1:
Example 2:
Peek.2022-04-27.14-57.mp4
Test 3:
Example 1:
Example 2:
Peek.2022-04-27.14-58.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.