Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkLaneIsInIntersection function caused no lane following trajectory to be generated during lane change #810

Closed
3 tasks done
zulfaqar-azmi-t4 opened this issue Apr 26, 2022 · 0 comments
Assignees
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.

Comments

@zulfaqar-azmi-t4
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

During lane change, no lane following path is generated.
Screenshot from 2022-04-26 09-27-25

Expected behavior

If the distance is sufficient, a lane following trajectory should also be visualize

Actual behavior

The should be two path generated in this case, the first is the lane following trajectory, and another is the candidate path.
Screenshot from 2022-04-26 09-25-07

Steps to reproduce

  1. Run autoware
  2. Select start and end pose. Then end pose should be a lane change and should not place after intersection.

Versions

  • OS: Ubuntu 20.04
  • ROS: Galactic
  • Autoware: Universe

Possible causes

To check for an intersection, checkLaneIsInIntersection requires at least two lanelets in the lane sequence.

However, the lane sequence size check only look for empty and not size == 1

bool checkLaneIsInIntersection(
  const RouteHandler & route_handler, const PathWithLaneId & reference_path,
  const lanelet::ConstLanelets & lanelet_sequence, double & additional_length_to_add)
{
  if (lanelet_sequence.empty()) {
    return false;
  }

 .......
}

Additional context

No response

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 26, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 self-assigned this Apr 26, 2022
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this issue Jan 10, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this issue Jan 17, 2025
…ehavior path planner (autowarefoundation#810)

* Add sampling based planner params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update keep_last param

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* change priority of sampling based planner

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* Set parameters for frenet planner

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* changes for testing

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* change curvature weight for testing

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* tuning params

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* tuning

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* for integ w/ other modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add support for soft constraints weight reconfig

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* rebase

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* temp

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* update default params

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* Tune params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Set defaults back to normal

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix name of ablc

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* formatting fix

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* set verbose to false

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

No branches or pull requests

1 participant