Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multi_object_tracker): bring parameter schema to new package folder #8105

Conversation

technolojin
Copy link
Contributor

Description

Align two changes into one place.
#8083
#7333

As result, bringing newly added files need to be moved to new package named folder.

Related links

Parent Issue: autowarefoundation/autoware#4569

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin marked this pull request as ready for review July 19, 2024 06:18
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title refactor: bring parameter schema to new package folder refactor(multi_object_tracker): bring parameter schema to new package folder Jul 19, 2024
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.02%. Comparing base (33fe8a3) to head (78b5ef0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8105      +/-   ##
==========================================
- Coverage   29.02%   29.02%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      117837   117840       +3     
  Branches    50721    50720       -1     
==========================================
  Hits        34207    34207              
- Misses      74483    74486       +3     
  Partials     9147     9147              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.03% <ø> (+<0.01%) ⬆️ Carriedforward from 33fe8a3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 34e33c8 into autowarefoundation:main Jul 19, 2024
40 of 41 checks passed
@technolojin technolojin deleted the refactor/multi_object_tracker-take_missing_files branch July 22, 2024 09:38
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
… folder (autowarefoundation#8105)

refactor: bring parameter schema to new package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
… folder (autowarefoundation#8105)

refactor: bring parameter schema to new package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
… folder (autowarefoundation#8105)

refactor: bring parameter schema to new package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants