Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(multi_object_tracker)!: add package name prefix of autoware_ #8083

Merged
merged 2 commits into from
Jul 19, 2024
Merged

refactor(multi_object_tracker)!: add package name prefix of autoware_ #8083

merged 2 commits into from
Jul 19, 2024

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 17, 2024 •
edited
Loading

Description

This PR adds the autoware_ prefix to the package name.

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin force-pushed the refactor/prefix-multi_object_tracker branch from 2fe586d to 33b3988 Compare July 18, 2024 02:07
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 18, 2024
@technolojin technolojin self-assigned this Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.32%. Comparing base (9a7f886) to head (e65229f).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8083      +/-   ##
==========================================
- Coverage   28.94%   28.32%   -0.62%     
==========================================
  Files        1606     1640      +34     
  Lines      117645   120131    +2486     
  Branches    50616    50853     +237     
==========================================
- Hits        34050    34031      -19     
- Misses      74380    76885    +2505     
  Partials     9215     9215
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 28.95% <ø> (+0.01%) ⬆️ Carriedforward from 9a7f886

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review July 18, 2024 04:20
yukkysaito
yukkysaito approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin force-pushed the refactor/prefix-multi_object_tracker branch from 33b3988 to e65229f Compare July 18, 2024 06:40
@technolojin technolojin enabled auto-merge (squash) July 18, 2024 06:42
YoshiRi
YoshiRi approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin
refactor: rename multi_object_tracker package to autoware_multi_objec…
670ae0e 
…t_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/prefix-multi_object_tracker branch from e65229f to 670ae0e Compare July 19, 2024 01:34
@technolojin technolojin disabled auto-merge July 19, 2024 01:34
@technolojin technolojin enabled auto-merge (squash) July 19, 2024 01:44
@technolojin technolojin merged commit 375ed18 into autowarefoundation:main Jul 19, 2024
21 of 23 checks passed
@technolojin technolojin mentioned this pull request Jul 19, 2024
Merged
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Jul 19, 2024
@technolojin @pre-commit-ci @yhisaki
refactor(multi_object_tracker)!: add package name prefix of autoware_ (…
b922e31 
…autowarefoundation#8083)

* refactor: rename multi_object_tracker package to autoware_multi_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@technolojin technolojin deleted the refactor/prefix-multi_object_tracker branch July 22, 2024 09:38
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@technolojin @pre-commit-ci @Ariiees
refactor(multi_object_tracker)!: add package name prefix of autoware_ (…
26af438 
…autowarefoundation#8083)

* refactor: rename multi_object_tracker package to autoware_multi_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
@technolojin @pre-commit-ci
refactor(multi_object_tracker)!: add package name prefix of autoware_ (…
c689b75 
…autowarefoundation#8083)

* refactor: rename multi_object_tracker package to autoware_multi_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@technolojin @pre-commit-ci @esteve
refactor(multi_object_tracker)!: add package name prefix of autoware_ (…
e46a27d 
…autowarefoundation#8083)

* refactor: rename multi_object_tracker package to autoware_multi_object_tracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@YoshiRi YoshiRi YoshiRi approved these changes

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@miursh miursh Awaiting requested review from miursh

Assignees

@technolojin technolojin

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technolojin @yukkysaito @YoshiRi