Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_surround_obstacle_checker): fix constVariableReference #8059

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck constVariableReference warnings

planning/autoware_surround_obstacle_checker/src/node.cpp:509:38: style: Variable 'ex' can be declared as reference to const [constVariableReference]
  } catch (tf2::TransformException & ex) {
                                     ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc July 16, 2024 11:17
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 16, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (77cb05c) to head (401b4d5).
Report is 5 commits behind head on main.

Files Patch % Lines
...ng/autoware_surround_obstacle_checker/src/node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8059      +/-   ##
==========================================
- Coverage   28.93%   28.92%   -0.01%     
==========================================
  Files        1605     1607       +2     
  Lines      117514   117545      +31     
  Branches    50505    50508       +3     
==========================================
  Hits        34003    34003              
- Misses      74274    74305      +31     
  Partials     9237     9237              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.93% <ø> (+<0.01%) ⬆️ Carriedforward from 77cb05c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit c3982a3 into autowarefoundation:main Jul 19, 2024
39 checks passed
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…utowarefoundation#8059)

fix:constVariableReference

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…utowarefoundation#8059)

fix:constVariableReference

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_constVariableReference_pla-1 branch July 23, 2024 01:16
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…utowarefoundation#8059)

fix:constVariableReference

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants