Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(universe_utils/motion_utils)!: add autoware namespace #7594

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 19, 2024

Description

I hope you will wait to merge other PR's until this PR is merged to avoid conflicts 🙏

change namespace

  • autoware_motion_utils -> autoware::motion_utils
  • autoware_universe_utils -> autoware::universe_utils

part of autowarefoundation/autoware#4569

related package renaming PRs

Tests performed

psim
image

lsim

image

2024/06/20 https://evaluation.tier4.jp/evaluation/reports/a2c3c0e1-5c8e-5060-84f1-e57ad0d06c1c/?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

namespace is changed

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kosuke55 added 2 commits June 20, 2024 00:24
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jun 19, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
@kosuke55
Copy link
Contributor Author

I hope you will wait to merge other PR's until this PR is merged to avoid conflicts 🙏

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 41.94978% with 393 lines in your changes missing coverage. Please review.

Project coverage is 29.03%. Comparing base (507e3f4) to head (56c575d).
Report is 65 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 40 Missing ⚠️
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 37 Missing ⚠️
..._checker/src/predicted_path_checker_node/utils.cpp 0.00% 19 Missing ⚠️
...toware_map_based_prediction/src/path_generator.cpp 20.00% 16 Missing ⚠️
..._path_checker_node/predicted_path_checker_node.cpp 0.00% 14 Missing ⚠️
...rsuit/autoware_pure_pursuit_lateral_controller.cpp 0.00% 13 Missing ⚠️
..._departure_checker_node/lane_departure_checker.cpp 0.00% 9 Missing ⚠️
.../src/tracker/motion_model/bicycle_motion_model.cpp 0.00% 9 Missing ⚠️
...ker/src/tracker/motion_model/ctrv_motion_model.cpp 0.00% 9 Missing ⚠️
...t_tracker/src/tracker/model/pedestrian_tracker.cpp 0.00% 8 Missing ⚠️
... and 86 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7594       +/-   ##
===========================================
+ Coverage   14.84%   29.03%   +14.19%     
===========================================
  Files        1999     1347      -652     
  Lines      139163   101385    -37778     
  Branches    43716    45072     +1356     
===========================================
+ Hits        20661    29442     +8781     
+ Misses      95731    63757    -31974     
+ Partials    22771     8186    -14585     
Flag Coverage Δ
differential 29.03% <41.94%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 19, 2024

-cuda build fails because no left space

image

@kosuke55 kosuke55 changed the title refactor(universe_utils/motion_utils): add autoware namespace refactor(universe_utils/motion_utils)!: add autoware namespace Jun 20, 2024
@mitsudome-r mitsudome-r enabled auto-merge (squash) June 20, 2024 01:20
@mitsudome-r mitsudome-r disabled auto-merge June 20, 2024 02:03
@mitsudome-r mitsudome-r merged commit 5aa747b into autowarefoundation:main Jun 20, 2024
56 of 60 checks passed
@mitsudome-r mitsudome-r deleted the refactor/autoware_ns branch June 20, 2024 02:04
@mitsudome-r
Copy link
Member

build with cuda was failing due to no disk space left on device, but there was test done locally with Logging simulator and planning simulator.
If there are any issues after merging, feel free to revert the change.

simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…arefoundation#7594)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants