-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(motion_utils)!: add autoware prefix and include dir #7539
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:feat/autoware_motion_utils
Jun 18, 2024
Merged
refactor(motion_utils)!: add autoware prefix and include dir #7539
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:feat/autoware_motion_utils
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
shmpwk,
taikitanaka3,
tkimura4,
mkuri,
TakaHoribe,
N-Eiki,
1222-takeshi,
brkay54,
ito-san,
TetsuKawa,
veqcc,
TomohitoAndo,
isamu-takagi,
mitsudome-r,
yukkysaito,
soblin,
maxime-clem,
zulfaqar-azmi-t4,
KeisukeShima,
scepter914,
miursh,
technolojin,
YoshiRi,
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu and
vividf
as code owners
June 17, 2024 17:29
github-actions
bot
added
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:tools
Utility and debugging software. (auto-assigned)
component:system
System design and integration. (auto-assigned)
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
labels
Jun 17, 2024
Merged
7 tasks
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7539 +/- ##
===========================================
+ Coverage 14.84% 28.42% +13.57%
===========================================
Files 1999 881 -1118
Lines 139163 75935 -63228
Branches 43716 33177 -10539
===========================================
+ Hits 20661 21582 +921
+ Misses 95731 48350 -47381
+ Partials 22771 6003 -16768
☔ View full report in Codecov by Sentry. |
4 tasks
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feat/autoware_motion_utils
branch
from
June 18, 2024 05:59
57bfbff
to
eaf3682
Compare
github-actions
bot
removed
the
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
label
Jun 18, 2024
danielsanchezaran
approved these changes
Jun 18, 2024
go-sakayori
approved these changes
Jun 18, 2024
4 tasks
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…efoundation#7539) refactor(motion_utils): add autoware prefix and include dir Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
refactor(motion_utils): add autoware prefix and include dir Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
component:system
System design and integration. (auto-assigned)
component:tools
Utility and debugging software. (auto-assigned)
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/orgs/autowarefoundation/discussions/4881
We apologize for the trouble regarding autoware_ prefix support for Planning/Control and appreciate your cooperation.
Thanks to your help, we are almost done with the individual node support.
As a final step, we are going to create a PR with significant changes, and we would like to inform you of them.
By this PR, We will change as
Although this PR contains many code changes, including a change to almost all nodes in planning/control, we plan to merge the change by a single PR for simplicity and to avoid conflicts and work-in-progress problems.
We will proceed with the utmost care so as not to bring any defects to the main branch, and we appreciate your understanding and cooperation.
related
autowarefoundation/autoware_tools#53
part of autowarefoundation/autoware#4569
Tests performed
psim
lsim
evaluator
https://evaluation.tier4.jp/evaluation/reports/5108f1ef-8656-58ba-96ae-1d831a471aaf?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/ffdd4991-3143-5338-b1e9-df6ba9903331?project_id=prd_jt
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.