Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gyro_odometer): add diagnostic #7188

Merge branch 'main' into feat/gyro_odometer/add_diagnostic

b23e8d3
Select commit
Loading
Failed to load commit list.
Merged

feat(gyro_odometer): add diagnostic #7188

Merge branch 'main' into feat/gyro_odometer/add_diagnostic
b23e8d3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 6, 2024 in 50s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method gyro_odometer_core.cpp: GyroOdometerNode::concatGyroAndOdometer
  • Code Duplication gyro_odometer_core.cpp

Annotations

Check warning on line 95 in localization/gyro_odometer/src/gyro_odometer_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: GyroOdometerNode::callbackImu,GyroOdometerNode::callbackVehicleTwist. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 271 in localization/gyro_odometer/src/gyro_odometer_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

GyroOdometerNode::concatGyroAndOdometer has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.