feat(gyro_odometer): add diagnostic #7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
github-actions
bot
added
type:documentation
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
YamatoAndo
force-pushed
the
feat/gyro_odometer/add_diagnostic
branch
from
b9fb1f6 to
756359b
Compare
YamatoAndo
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
SakodaShintaro
added
the
run:build-and-test-differential
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
SakodaShintaro
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
I ran the logging_simulator and confirmed that /diagnostics was displayed properly.
The autoware_auto_*** message type has just been updated, and twist does not appear in unupdated rosbags. When using such a rosbag, the warning was displayed in /diagnostics.
Since the diagnostics module is in camel case, it should be fixed based on the linter's suggestions, but you can fix in another pull request. This is because I believe that in the future the diagnostics module will be placed in localization_util and will be commonly used by various packages.
KYabuuchi
approved these changes
Jun 6, 2024
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jun 6, 2024
* add diagnostic Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix diag time stamp Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix spellcheck Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
* add diagnostic Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix diag time stamp Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix spellcheck Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* add diagnostic Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix diag time stamp Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix spellcheck Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add diagnostic for gyro_odometer
see readme.md for more details
Related links
Tests performed
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.