-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run_out): maintain run out stop wall #6732
feat(run_out): maintain run out stop wall #6732
Conversation
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6732 +/- ##
==========================================
- Coverage 14.94% 14.94% -0.01%
==========================================
Files 1943 1943
Lines 133963 133984 +21
Branches 39849 39861 +12
==========================================
+ Hits 20022 20025 +3
- Misses 91657 91669 +12
- Partials 22284 22290 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1eef4c0
into
autowarefoundation:main
* feat(run_out): maintain run_out stop walls for a given time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove printouts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * space Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add stop wall debug markers when maintaining stop points Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
* feat(run_out): maintain run_out stop walls for a given time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove printouts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * space Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add stop wall debug markers when maintaining stop points Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Description
When the run_out module outputs a stop point, it often causes a deceleration on the ego vehicle, but because the ego vehicle decelerates, it often happens that the initial collision target object is no longer detected as a collision candidate (because the ego vehicle slowed down and now the predicted collision using the obstacle's speed is no longer detected), which leads to the stop point promptly disappearing which can be somewhat unsafe.
For said reasons, it is probably best to maintain the stop point/stop wall of the run out module for a certain time, every time one is issued. This PR introduces that feature.
A parameter called "keep_stop_point_time" (default 1 second) is used to customize how long the stop wall will remain.
Example (with keep_stop_point_time set to 10 seconds):
cap-.2024-04-03-16-09-44.mp4
Related links
Ticket: TIER IV INTERNAL LINK
Tests performed
PSim
Evaluator tests: TIER IV's INTERNAL LINK -> No degradation
Notes for reviewers
Requires Launch changes: autowarefoundation/autoware_launch#944
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.