Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run_out): maintain run out stop wall #6732

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Apr 3, 2024

Description

When the run_out module outputs a stop point, it often causes a deceleration on the ego vehicle, but because the ego vehicle decelerates, it often happens that the initial collision target object is no longer detected as a collision candidate (because the ego vehicle slowed down and now the predicted collision using the obstacle's speed is no longer detected), which leads to the stop point promptly disappearing which can be somewhat unsafe.

For said reasons, it is probably best to maintain the stop point/stop wall of the run out module for a certain time, every time one is issued. This PR introduces that feature.

A parameter called "keep_stop_point_time" (default 1 second) is used to customize how long the stop wall will remain.

Example (with keep_stop_point_time set to 10 seconds):

cap-.2024-04-03-16-09-44.mp4

Related links

Ticket: TIER IV INTERNAL LINK

Tests performed

PSim
Evaluator tests: TIER IV's INTERNAL LINK -> No degradation

Notes for reviewers

Requires Launch changes: autowarefoundation/autoware_launch#944

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 3, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review April 3, 2024 07:47
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 14.94%. Comparing base (f97cdc0) to head (f5ef704).
Report is 9 commits behind head on main.

Files Patch % Lines
...ing/behavior_velocity_run_out_module/src/scene.cpp 28.00% 12 Missing and 6 partials ⚠️
...g/behavior_velocity_run_out_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6732      +/-   ##
==========================================
- Coverage   14.94%   14.94%   -0.01%     
==========================================
  Files        1943     1943              
  Lines      133963   133984      +21     
  Branches    39849    39861      +12     
==========================================
+ Hits        20022    20025       +3     
- Misses      91657    91669      +12     
- Partials    22284    22290       +6     
Flag Coverage Δ *Carryforward flag
differential 18.02% <26.92%> (?)
total 14.94% <ø> (-0.01%) ⬇️ Carriedforward from f97cdc0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielsanchezaran danielsanchezaran merged commit 1eef4c0 into autowarefoundation:main Apr 5, 2024
40 of 43 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/maintain_run_out_stop_wall branch April 5, 2024 10:05
esteve pushed a commit that referenced this pull request Apr 9, 2024
* feat(run_out): maintain run_out stop walls for a given  time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove printouts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* space

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add stop wall debug markers when maintaining stop points

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat(run_out): maintain run_out stop walls for a given  time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove printouts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* space

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add stop wall debug markers when maintaining stop points

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants