Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning hz of detected_object_validator #631

Merged

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Apr 5, 2022

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

Description

fix warning hz of detected_object_validator

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito requested a review from tkimura4 April 5, 2022 04:44
@yukkysaito yukkysaito enabled auto-merge (squash) April 5, 2022 04:45
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #631 (b623d97) into main (5153502) will decrease coverage by 10.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #631       +/-   ##
==========================================
- Coverage   10.74%   0.00%   -10.75%     
==========================================
  Files         713       3      -710     
  Lines       50671     268    -50403     
  Branches     6572       0     -6572     
==========================================
- Hits         5443       0     -5443     
+ Misses      40821     268    -40553     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% <0.00%> (ø)
..._validation/src/occupancy_grid_based_validator.cpp 0.00% <ø> (ø)
...ject_tracker/src/tracker/model/unknown_tracker.cpp
...re_auto_geometry/include/geometry/lookup_table.hpp
...analysis/src/control_performance_analysis_core.cpp
...nning/mission_planner/lib/mission_planner_base.cpp
...ior_path_planner/scene_module/approval_handler.hpp
...ystem_monitor/src/gpu_monitor/gpu_monitor_base.cpp
...ner/src/scene_module/avoidance/avoidance_utils.cpp
...test/src/test_planning_error_monitor_functions.cpp
... and 702 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5153502...b623d97. Read the comment docs.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit b6d9c4a into autowarefoundation:main Apr 5, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Apr 5, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
soblin added a commit to soblin/autoware.universe that referenced this pull request Jul 25, 2023
…p line idx is 0 (autowarefoundation#4097) (autowarefoundation#631)

fix(intersection): do not plan if detection area is not empty and stop line idx is 0 (autowarefoundation#4097)

do not plan if detection area is not empty and stop line idx is 0

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants