Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): rework params #6209

Merged
merged 3 commits into from
Jan 31, 2024

fix: ray ground filter gtest

ffa396f
Select commit
Loading
Failed to load commit list.
Merged

chore(ground_segmentation): rework params #6209

fix: ray ground filter gtest
ffa396f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 29, 2024 in 45s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_ray_ground_filter.cpp: TEST:RayGroundFilterComponentTestSuite:TestCase1

Annotations

Check warning on line 130 in perception/ground_segmentation/test/test_ray_ground_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method 

TEST:RayGroundFilterComponentTestSuite:TestCase1 has 76 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis