Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): rework params #6209

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 29, 2024

Description

Tests performed

  • Confirm each node of ground_segmentation successfully loads the default paramters from yaml file.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 29, 2024
@badai-nguyen badai-nguyen requested a review from kminoda January 29, 2024 09:43
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed that

  • Autoware launches with this PR (and related PRs).
  • Parameters are successfully modified when I modify the .param.yaml file.
  • ROS 2 test passes

See also: TIER IV INTERNAL LINK FOR REWORK PRs

@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2024
@badai-nguyen badai-nguyen enabled auto-merge (squash) January 31, 2024 10:29
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (5b91874) 14.61% compared to head (ffa396f) 14.60%.
Report is 31 commits behind head on main.

Files Patch % Lines
...round_segmentation/test/test_ray_ground_filter.cpp 0.00% 0 Missing and 29 partials ⚠️
...ound_segmentation/test/test_scan_ground_filter.cpp 3.33% 0 Missing and 29 partials ⚠️
...nd_segmentation/src/scan_ground_filter_nodelet.cpp 0.00% 0 Missing and 15 partials ⚠️
..._segmentation/src/ransac_ground_filter_nodelet.cpp 0.00% 12 Missing ⚠️
...und_segmentation/src/ray_ground_filter_nodelet.cpp 0.00% 0 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6209      +/-   ##
==========================================
- Coverage   14.61%   14.60%   -0.01%     
==========================================
  Files        1874     1874              
  Lines      127801   127833      +32     
  Branches    37369    37402      +33     
==========================================
- Hits        18674    18673       -1     
  Misses      88156    88156              
- Partials    20971    21004      +33     
Flag Coverage Δ *Carryforward flag
differential 34.62% <1.02%> (?)
total 14.61% <ø> (+<0.01%) ⬆️ Carriedforward from 5b91874

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit debe198 into autowarefoundation:main Jan 31, 2024
32 of 36 checks passed
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 3, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 8, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Apr 10, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 11, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 14, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 16, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 16, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 19, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Apr 22, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* chore: remove default params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: scan ground gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: ray ground filter gtest

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants