-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ground_segmentation): rework params #6209
chore(ground_segmentation): rework params #6209
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Confirmed that
- Autoware launches with this PR (and related PRs).
- Parameters are successfully modified when I modify the .param.yaml file.
- ROS 2 test passes
See also: TIER IV INTERNAL LINK FOR REWORK PRs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6209 +/- ##
==========================================
- Coverage 14.61% 14.60% -0.01%
==========================================
Files 1874 1874
Lines 127801 127833 +32
Branches 37369 37402 +33
==========================================
- Hits 18674 18673 -1
Misses 88156 88156
- Partials 20971 21004 +33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
* chore: remove default params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: scan ground gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: ray ground filter gtest Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
Tests performed
ground_segmentation
successfully loads the default paramters from yaml file.Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.