Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): add missing install #5548

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 10, 2023

Description

add missing install for pointpainting cuda lib

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 10, 2023
@wep21 wep21 requested a review from tzhong518 November 10, 2023 04:58
@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4db9fc5) 15.36% compared to head (60fa008) 15.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5548      +/-   ##
==========================================
- Coverage   15.36%   15.33%   -0.04%     
==========================================
  Files        1697     1702       +5     
  Lines      117472   117709     +237     
  Branches    37762    37762              
==========================================
  Hits        18049    18049              
- Misses      78873    79110     +237     
  Partials    20550    20550              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.36% <ø> (ø) Carriedforward from 4db9fc5

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit ce0f11a into main Nov 10, 2023
31 of 33 checks passed
@wep21 wep21 deleted the fix-missing-install-pp branch November 10, 2023 06:19
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants