Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): add acceleration and steer command scaling factor for debug #5534

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 9, 2023

Description

add acceleration and steer command scaling factor for debug

before

image

after (if set 0.8 for steer)

image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…caling factor

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:simulator labels Nov 9, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 changed the title feat(simple_planning_simulator): add acceleration and steer command scaling factor feat(simple_planning_simulator): add acceleration and steer command scaling factor for debug Nov 9, 2023
@kosuke55
Copy link
Contributor Author

kosuke55 commented Nov 9, 2023

This is for hacky debugging, so the param file is intentionally not updated

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4f2d513) 15.36% compared to head (7880ea6) 15.36%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5534   +/-   ##
=======================================
  Coverage   15.36%   15.36%           
=======================================
  Files        1697     1697           
  Lines      117472   117478    +6     
  Branches    37759    37763    +4     
=======================================
+ Hits        18045    18050    +5     
+ Misses      78884    78883    -1     
- Partials    20543    20545    +2     
Flag Coverage Δ *Carryforward flag
differential 57.03% <28.57%> (?)
total 15.36% <ø> (-0.01%) ⬇️ Carriedforward from 4f2d513

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ulator/vehicle_model/sim_model_delay_steer_acc.hpp 100.00% <ø> (ø)
...vehicle_model/sim_model_delay_steer_acc_geared.hpp 100.00% <ø> (ø)
...nning_simulator/simple_planning_simulator_core.cpp 35.58% <0.00%> (-0.18%) ⬇️
...ulator/vehicle_model/sim_model_delay_steer_acc.cpp 79.72% <33.33%> (-0.83%) ⬇️
...vehicle_model/sim_model_delay_steer_acc_geared.cpp 80.00% <33.33%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit a37b4f3 into main Nov 13, 2023
35 of 37 checks passed
@kosuke55 kosuke55 deleted the feat/sim_cmd_scaling_main branch November 13, 2023 04:23
@xmfcx xmfcx added component:simulation Virtual environment setups and simulations. (auto-assigned) and removed component:simulator labels Nov 14, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…caling factor for debug (autowarefoundation#5534)

* feat(simple_planning_simulator): add acceleration and steer command scaling factor

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update params as debug

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants