Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_launch): align argument name #5505

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 7, 2023

Description

🤖 Generated by Copilot at fd7862c

This pull request enhances the behavior planning nodes for lane driving scenarios by introducing launch arguments and parameters to control the modules to load and run. It also reorganizes the launch files and configuration files to improve the flexibility and simplicity of the node setup. It affects the files behavior_planning.launch.xml, scene_module_manager.param.yaml, motion_planning.launch.xml, and behavior_velocity_planner.param.yaml.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 7, 2023
@satoshi-ota satoshi-ota force-pushed the feat/configurable-planning-preset branch 3 times, most recently from 951516e to e49c274 Compare November 8, 2023 00:09
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 8, 2023
@satoshi-ota satoshi-ota force-pushed the feat/configurable-planning-preset branch from e49c274 to 65ae393 Compare November 8, 2023 03:37
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 8, 2023
@satoshi-ota satoshi-ota force-pushed the feat/configurable-planning-preset branch from 65ae393 to fd7862c Compare November 8, 2023 03:46
@satoshi-ota satoshi-ota marked this pull request as ready for review November 8, 2023 05:14
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@satoshi-ota satoshi-ota force-pushed the feat/configurable-planning-preset branch from fd7862c to f3bd49f Compare November 8, 2023 10:16
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/configurable-planning-preset branch from f3bd49f to f87c072 Compare November 8, 2023 14:13
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (328bfa6) 14.96% compared to head (f87c072) 15.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5505      +/-   ##
==========================================
+ Coverage   14.96%   15.03%   +0.06%     
==========================================
  Files        1684     1684              
  Lines      116871   116899      +28     
  Branches    36802    36830      +28     
==========================================
+ Hits        17487    17573      +86     
+ Misses      79528    79172     -356     
- Partials    19856    20154     +298     
Flag Coverage Δ *Carryforward flag
differential 13.04% <0.00%> (?)
total 14.96% <ø> (ø) Carriedforward from 328bfa6

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...test/test_behavior_path_planner_node_interface.cpp 23.07% <0.00%> (-6.20%) ⬇️
..._velocity_planner/test/src/test_node_interface.cpp 19.69% <0.00%> (-6.84%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 5797ee5 into autowarefoundation:main Nov 8, 2023
22 of 24 checks passed
@satoshi-ota satoshi-ota deleted the feat/configurable-planning-preset branch November 8, 2023 23:09
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Nov 9, 2023
…ion#5505)

* chore(tier4_planning_launch): align arument name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(tier4_planning_launch): pass params directly

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…ion#5505)

* chore(tier4_planning_launch): align arument name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(tier4_planning_launch): pass params directly

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants