-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tier4_planning_launch): align argument name #5505
refactor(tier4_planning_launch): align argument name #5505
Conversation
951516e
to
e49c274
Compare
e49c274
to
65ae393
Compare
65ae393
to
fd7862c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
fd7862c
to
f3bd49f
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
f3bd49f
to
f87c072
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5505 +/- ##
==========================================
+ Coverage 14.96% 15.03% +0.06%
==========================================
Files 1684 1684
Lines 116871 116899 +28
Branches 36802 36830 +28
==========================================
+ Hits 17487 17573 +86
+ Misses 79528 79172 -356
- Partials 19856 20154 +298
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…ion#5505) * chore(tier4_planning_launch): align arument name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(tier4_planning_launch): pass params directly Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ion#5505) * chore(tier4_planning_launch): align arument name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(tier4_planning_launch): pass params directly Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at fd7862c
This pull request enhances the behavior planning nodes for lane driving scenarios by introducing launch arguments and parameters to control the modules to load and run. It also reorganizes the launch files and configuration files to improve the flexibility and simplicity of the node setup. It affects the files
behavior_planning.launch.xml
,scene_module_manager.param.yaml
,motion_planning.launch.xml
, andbehavior_velocity_planner.param.yaml
.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.