build(lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes): remove download from cmake #5431

lexavtanke · 2023-10-27T11:00:06Z

Description

According to #3137.

This PR updates lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes packages. Now they use updated version of function get_neural_network which do not download neural networks files. Configuration headers of compiled nets are part of the source tree for now. The rest of the networks files is expected to be in autoware_data folder under lidar_apollo_segmentation directory.

Tests are removed from lidar_apollo_segmentation_tvm package as they require model files as test fixture which weights 11.9 Mb and can't be part of the source tree. Because we can't use git-lfs for autoware-universe repo. See #4923

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

…entation Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

… into remove_download_tvm_utility

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

…nn config header and test image Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

…d on device Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

…ownload

perception/lidar_apollo_segmentation_tvm/CMakeLists.txt

…ownload

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

perception/lidar_apollo_segmentation_tvm/test/main.cpp

codecov · 2023-11-07T11:18:07Z

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (ee20545) 14.86% compared to head (6260712) 14.76%.
Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5431      +/-   ##
==========================================
- Coverage   14.86%   14.76%   -0.10%     
==========================================
  Files        1666     1677      +11     
  Lines      116258   116739     +481     
  Branches    36266    36435     +169     
==========================================
- Hits        17277    17242      -35     
- Misses      79476    79988     +512     
- Partials    19505    19509       +4

Flag	Coverage Δ		*Carryforward flag
differential	`1.25% <4.54%> (?)`
total	`14.83% <ø> (-0.03%)`	⬇️	Carriedforward from 7a77479

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...entation_tvm/src/lidar_apollo_segmentation_tvm.cpp	`0.00% <0.00%> (ø)`
...m_nodes/src/lidar_apollo_segmentation_tvm_node.cpp	`0.00% <0.00%> (ø)`
...eption/lidar_apollo_segmentation_tvm/test/main.cpp	`5.76% <5.00%> (ø)`

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

ambroise-arm

LGTM

…_nodes): remove download from cmake (autowarefoundation#5431) * add include tier4_autoware_utils and dependency Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * remove downloading logic from Cmake, update documentation Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): remove downloading logic from Cmake, update documentation Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): fix lint_cmake error Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): format warning message Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): add logic to work with autoware_data folder, add nn config header and test image Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * style(pre-commit): autofix * build(tvm_utility): refactor, update InferenceEngineTVM constructor Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): add lightweight model and test with it Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): make building yolo_v2_tiny disable by default Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): remove test artifact for yolo_v2_tiny Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): update docs Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): update docs Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): update namespace in abs_model test Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): rewrite yolo_v2_tiny as example Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): clean comments in yolo_v2_tiny example main.cpp Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): add launch file for yolo_v2_tiny example Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): update yolo_v2_tiny example readme Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): add model for arm based systems, need to be tested on device Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * style(pre-commit): autofix * build(tvm_utility): update config header for arm Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): remove debug output Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): add find_package conditional section Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): fix lint_cmake errors Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): remove coping model files during build Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): update readme with new data folder structure Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): fix spell check warnings Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): add no model files guard to get_neural_network Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): set back default paths in config headers Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation): wip update launch files Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): add param file, update launch file Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): add schema file, update node name Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): fix json-schema-check Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): fix json-schema-check Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(tvm_utility): add parameter table to example readme Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(tvm_utility): fix typo-error in description of schema.json Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * buiild(tvm_utility): fix spell-check warning and typo Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * feat(spell-check): add dltype and tvmgen to local dict Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(lidar_apollo_segmentation_tvm): remove test Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): add data_path to constructor Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm_nodes): add data_path to param file Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm_nodes): add allow_substs to launches Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(lidar_apollo_segmentation_tvm_nodes): update README Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): update README Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm_nodes): fix schema typo Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): remove unused import Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): suppress cpplint Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): suppress cpplint Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmentation_tvm): return test back and update it Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix * build(lidar_apollo_segmentation_tvm): fix cpplilnt errors Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * build(lidar_apollo_segmenntation_tvm): update checking for models files Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

lexavtanke and others added 30 commits September 7, 2023 18:10

add include tier4_autoware_utils and dependency

c90b228

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

remove downloading logic from Cmake, update documentation

e77245c

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): remove downloading logic from Cmake, update docum…

59c590f

…entation Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

Merge remote-tracking branch 'lexavtanke/remove_download_tvm_utility'…

deab5e7

… into remove_download_tvm_utility

style(pre-commit): autofix

d4e0064

build(tvm_utility): fix lint_cmake error

a098b48

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): format warning message

dac7a20

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): add logic to work with autoware_data folder, add …

789ba72

…nn config header and test image Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

0fa9061

Merge branch 'autowarefoundation:main' into remove_download_tvm_utility

4060e78

style(pre-commit): autofix

726e3a2

Merge branch 'main' into remove_download_tvm_utility

f9d23be

build(tvm_utility): refactor, update InferenceEngineTVM constructor

a602a34

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

e2ad796

Merge branch 'autowarefoundation:main' into remove_download_tvm_utility

1c46e02

build(tvm_utility): add lightweight model and test with it

b218bbe

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): make building yolo_v2_tiny disable by default

6eea3e9

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): remove test artifact for yolo_v2_tiny

dd09064

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): update docs

3cf6108

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): update docs

e82b412

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

5ed5724

build(tvm_utility): update namespace in abs_model test

7ba6056

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): rewrite yolo_v2_tiny as example

c45ab80

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): clean comments in yolo_v2_tiny example main.cpp

c91c0e2

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): add launch file for yolo_v2_tiny example

f145dbc

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(tvm_utility): update yolo_v2_tiny example readme

6d86664

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

24aee4b

build(tvm_utility): add model for arm based systems, need to be teste…

3484369

…d on device Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

165255a

Merge branch 'autowarefoundation:main' into remove_download_tvm_utility

0c08dc3

lexavtanke added 3 commits October 27, 2023 14:38

build(lidar_apollo_segmentation_tvm): update README

431deae

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(lidar_apollo_segmentation_tvm_nodes): fix schema typo

af0e556

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(lidar_apollo_segmentation_tvm): remove unused import

5126be5

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

lexavtanke mentioned this pull request Oct 27, 2023

Move downloading artifacts outside CMake #3137

Closed

38 tasks

lexavtanke added 2 commits October 27, 2023 15:40

build(lidar_apollo_segmentation_tvm): suppress cpplint

e3b708e

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

build(lidar_apollo_segmentation_tvm): suppress cpplint

d7ff9e3

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

lexavtanke marked this pull request as ready for review October 27, 2023 13:23

lexavtanke requested review from ambroise-arm and angry-crab as code owners October 27, 2023 13:23

Merge branch 'main' into build-lidar-apollo-segmentation-tvm-remove-d…

04f17a7

…ownload

github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 1, 2023

ambroise-arm requested changes Nov 3, 2023

View reviewed changes

perception/lidar_apollo_segmentation_tvm/CMakeLists.txt Outdated Show resolved Hide resolved

lexavtanke and others added 4 commits November 6, 2023 11:33

Merge branch 'main' into build-lidar-apollo-segmentation-tvm-remove-d…

893f746

…ownload

build(lidar_apollo_segmentation_tvm): return test back and update it

18febc7

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

ab85c5b

build(lidar_apollo_segmentation_tvm): fix cpplilnt errors

7a77479

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

lexavtanke requested a review from ambroise-arm November 6, 2023 21:34

ambroise-arm added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2023

ambroise-arm reviewed Nov 7, 2023

View reviewed changes

perception/lidar_apollo_segmentation_tvm/test/main.cpp Outdated Show resolved Hide resolved

lexavtanke and others added 2 commits November 8, 2023 10:59

build(lidar_apollo_segmenntation_tvm): update checking for models files

f3a0717

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

style(pre-commit): autofix

6260712

ambroise-arm approved these changes Nov 8, 2023

View reviewed changes

lexavtanke merged commit 934db6c into autowarefoundation:main Nov 8, 2023
20 of 26 checks passed

lexavtanke deleted the build-lidar-apollo-segmentation-tvm-remove-download branch November 10, 2023 09:48

tier4-autoware-public-bot bot mentioned this pull request Nov 22, 2023

chore: sync upstream tier4/autoware.universe#1034

Merged

tier4-autoware-public-bot bot mentioned this pull request Nov 22, 2023

chore: sync upstream tier4/autoware.universe#1035

Merged

kminoda mentioned this pull request Dec 4, 2023

Test of lidar_apollo_segmentation_tvm failing in CI #5765

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes): remove download from cmake #5431

build(lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes): remove download from cmake #5431

lexavtanke commented Oct 27, 2023

codecov bot commented Nov 7, 2023 •

edited

Loading

ambroise-arm left a comment

build(lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes): remove download from cmake #5431

build(lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes): remove download from cmake #5431

Conversation

lexavtanke commented Oct 27, 2023

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Nov 7, 2023 • edited Loading

Codecov Report

ambroise-arm left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 7, 2023 •

edited

Loading