Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lidar_centerpoint_tvm): remove artifacts download #5367

Conversation

lexavtanke
Copy link
Contributor

@lexavtanke lexavtanke commented Oct 20, 2023

Description

See #3137
This PR updates lidar_centerpoint_tvm to use updated version get_neural_network function from tvm_utility package introduced in #4923.
It also uses artifacts located in autoware_data folder as introduced in autowarefoundation/autoware#3916

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

lexavtanke and others added 30 commits September 7, 2023 18:10
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…entation

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…nn config header and test image

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…d on device

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
@lexavtanke lexavtanke marked this pull request as ready for review October 27, 2023 12:17
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
@xmfcx
Copy link
Contributor

xmfcx commented Nov 1, 2023

Thanks for this PR!

Could you resolve the conflicts for the .cspell-partial.json file?

@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 1, 2023
@lexavtanke lexavtanke added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4db9fc5) 15.36% compared to head (1e2ac27) 14.82%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5367      +/-   ##
==========================================
- Coverage   15.36%   14.82%   -0.54%     
==========================================
  Files        1697     1678      -19     
  Lines      117472   116195    -1277     
  Branches    37762    35949    -1813     
==========================================
- Hits        18049    17227     -822     
- Misses      78873    79489     +616     
+ Partials    20550    19479    -1071     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.89% <ø> (-0.47%) ⬇️ Carriedforward from 1a0aced

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ils/include/motion_utils/trajectory/trajectory.hpp 65.65% <ø> (ø)
perception/lidar_centerpoint_tvm/src/node.cpp 0.00% <0.00%> (ø)
...idar_centerpoint_tvm/src/single_inference_node.cpp 0.00% <0.00%> (ø)
...tion/lidar_centerpoint_tvm/lib/centerpoint_tvm.cpp 0.00% <0.00%> (ø)

... and 130 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
@lexavtanke
Copy link
Contributor Author

@angry-crab Could you please approve the changes when you have time? You are the code owner of this package. @ambroise-arm has reviewed and approved the changes, but they won't merge unless a code owner also approves it.
Thank you in advance!

@lexavtanke lexavtanke enabled auto-merge (squash) November 10, 2023 09:47
@xmfcx xmfcx disabled auto-merge November 10, 2023 10:24
@xmfcx xmfcx merged commit 208ecf2 into autowarefoundation:main Nov 10, 2023
17 of 23 checks passed
@lexavtanke lexavtanke deleted the build-lidar-centerpoint-tvm-remove-artifacts-download branch November 10, 2023 10:44
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants