Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(obstacle_velocity_limiter): publish processing time as float #5257

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Oct 10, 2023

Description

Use Float64 msg for processing time as other planning modules do.

Tests performed

run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 10, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c508aa7) 14.76% compared to head (4fd429e) 14.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5257      +/-   ##
==========================================
- Coverage   14.76%   14.76%   -0.01%     
==========================================
  Files        1644     1644              
  Lines      113948   113949       +1     
  Branches    35160    35161       +1     
==========================================
  Hits        16824    16824              
  Misses      78179    78179              
- Partials    18945    18946       +1     
Flag Coverage Δ *Carryforward flag
differential 27.40% <0.00%> (?)
total 14.76% <ø> (+<0.01%) ⬆️ Carriedforward from c508aa7

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_limiter/src/obstacle_velocity_limiter_node.cpp 16.33% <0.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe merged commit 2aa9d1c into autowarefoundation:main Oct 11, 2023
33 of 36 checks passed
@TakaHoribe TakaHoribe deleted the obstacle-velocity-limit-double-processing-timer branch October 11, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants