Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(safety_check): support lambda function in target filtering logic #5210

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 3, 2023

Description

🤖 Generated by Copilot at dc4d64f

This pull request enhances the behavior path planner by adding polygon utilities and custom filtering functions for predicted objects by lanelets. These changes improve the logic and performance of the goal planner, the avoidance by lane change, the start planner, and the path safety checker modules. The pull request also refactors some existing functions and adds a new function toPolygon2d to convert lanelets to polygons.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 3, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review October 3, 2023 06:22
@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 3, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the refactor/use-common-filter branch 2 times, most recently from d4c2cd9 to 6d09dca Compare October 3, 2023 09:26
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 4, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) October 4, 2023 23:45
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (68544c7) 14.80% compared to head (6d09dca) 14.80%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5210      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1648     1648              
  Lines      113860   113898      +38     
  Branches    35049    35059      +10     
==========================================
  Hits        16861    16861              
- Misses      78081    78119      +38     
  Partials    18918    18918              
Flag Coverage Δ *Carryforward flag
differential 12.50% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 68544c7

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...rc/utils/path_safety_checker/objects_filtering.cpp 7.94% <0.00%> (+0.30%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 5.58% <0.00%> (-0.04%) ⬇️
...ne_module/lane_change/avoidance_by_lane_change.cpp 0.00% <0.00%> (ø)
...cene_module/start_planner/start_planner_module.cpp 7.04% <0.00%> (-0.06%) ⬇️
...h_planner/src/utils/goal_planner/goal_searcher.cpp 1.37% <0.00%> (-0.04%) ⬇️
...ner/src/utils/start_planner/geometric_pull_out.cpp 7.14% <0.00%> (-0.97%) ⬇️
...planner/src/utils/start_planner/shift_pull_out.cpp 2.43% <0.00%> (-0.08%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 13.59% <0.00%> (-0.07%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.54% <0.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 8649d93 into autowarefoundation:main Oct 5, 2023
17 of 19 checks passed
@satoshi-ota satoshi-ota deleted the refactor/use-common-filter branch October 5, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants