Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_centerpoint): add arg data_path, update model path #5162

Conversation

lexavtanke
Copy link
Contributor

@lexavtanke lexavtanke commented Sep 27, 2023

Description

Belongs to Standardize a strategy for packages with downloaded artifacts
As autowarefoundation/autoware#3375 was merged to Autoware.universe. It is possible to use artifacts downloaded there.
#3141 was merged and the old path to the model file is outdated.

This PR introduces a new launch argument data_path in the form:
<arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/>
It also updates classifier_model_path and classifier_label_path args.

See #3137

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 27, 2023
@lexavtanke lexavtanke marked this pull request as ready for review September 27, 2023 12:54
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexavtanke lexavtanke added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3eda018) 14.85% compared to head (fc4d882) 14.80%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
- Coverage   14.85%   14.80%   -0.06%     
==========================================
  Files        1627     1652      +25     
  Lines      112674   113135     +461     
  Branches    34814    34625     -189     
==========================================
+ Hits        16741    16746       +5     
- Misses      77170    77664     +494     
+ Partials    18763    18725      -38     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.92% <ø> (+0.06%) ⬆️ Carriedforward from 16dc535

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...onitor/include/localization_error_monitor/node.hpp 0.00% <ø> (ø)
...calization/localization_error_monitor/src/node.cpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.43% <ø> (+0.13%) ⬆️

... and 79 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lexavtanke lexavtanke merged commit aa90375 into autowarefoundation:main Sep 28, 2023
@lexavtanke lexavtanke deleted the fix-lidar-centerpoint-update-model-path branch September 28, 2023 13:11
miursh pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants