-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lidar_centerpoint): add arg data_path, update model path #5162
fix(lidar_centerpoint): add arg data_path, update model path #5162
Conversation
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5162 +/- ##
==========================================
- Coverage 14.85% 14.80% -0.06%
==========================================
Files 1627 1652 +25
Lines 112674 113135 +461
Branches 34814 34625 -189
==========================================
+ Hits 16741 16746 +5
- Misses 77170 77664 +494
+ Partials 18763 18725 -38
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…efoundation#5162) Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Description
Belongs to Standardize a strategy for packages with downloaded artifacts
As autowarefoundation/autoware#3375 was merged to Autoware.universe. It is possible to use artifacts downloaded there.
#3141 was merged and the old path to the model file is outdated.
This PR introduces a new launch argument data_path in the form:
<arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/>
It also updates classifier_model_path and classifier_label_path args.
See #3137
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.