Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gnss_poser): rework parameters #5140

Merged

Conversation

SKT-r
Copy link
Contributor

@SKT-r SKT-r commented Sep 26, 2023

Description

Removed default parameters in the C++ codes in gnss_poser

Tests performed

It is able to build gnss_poser locally.
It is also confirmed that the logging_simulator on the tutorial works fine.

Effects on system behavior

Less prone to unexpected behavior when parameter definitions are incomplete.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: SKT-r <ryoma.sakata@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Sep 26, 2023
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (aae343b) 15.71% compared to head (517c7ea) 15.72%.
Report is 113 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5140   +/-   ##
=======================================
  Coverage   15.71%   15.72%           
=======================================
  Files        1579     1579           
  Lines      109343   109333   -10     
  Branches    34110    34103    -7     
=======================================
+ Hits        17185    17188    +3     
+ Misses      73247    73230   -17     
- Partials    18911    18915    +4     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.72% <8.10%> (+<0.01%) ⬆️ Carriedforward from 3a9b2b7

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
...calizer/include/ekf_localizer/hyper_parameters.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <ø> (+0.01%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.04% <0.00%> (-0.01%) ⬇️
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% <0.00%> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 5.29% <0.00%> (-0.06%) ⬇️
... and 4 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as ready for review September 27, 2023 04:00
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants