-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gnss_poser): rework parameters #5140
refactor(gnss_poser): rework parameters #5140
Conversation
Signed-off-by: SKT-r <ryoma.sakata@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5140 +/- ##
=======================================
Coverage 15.71% 15.72%
=======================================
Files 1579 1579
Lines 109343 109333 -10
Branches 34110 34103 -7
=======================================
+ Hits 17185 17188 +3
+ Misses 73247 73230 -17
- Partials 18911 18915 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Removed default parameters in the C++ codes in gnss_poser
Tests performed
It is able to build gnss_poser locally.
It is also confirmed that the logging_simulator on the tutorial works fine.
Effects on system behavior
Less prone to unexpected behavior when parameter definitions are incomplete.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.