build(landmark_tf_caster): add missing libopencv-dev dependency #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:localization
esteve
added
run:build-and-test-differential
|
@SakodaShintaro @xmfcx @mitsudome-r could you have a look at this PR? It's a very small change. Thanks. |
SakodaShintaro
approved these changes
Sep 26, 2023
|
@SakodaShintaro no problem, thanks for reviewing this PR so quickly 🙂 |
esteve
force-pushed
the
add-build-depend-landmark-tf-caster
branch
from
014312f to
d185ceb
Compare
github-actions
bot
added
the
component:localization
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
esteve
force-pushed
the
add-build-depend-landmark-tf-caster
branch
from
d185ceb to
9a0f2f1
Compare
esteve
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 14.89% 14.89%
=======================================
Files 1625 1625
Lines 112449 112449
Branches 34712 34712
=======================================
Hits 16752 16752
Misses 76959 76959
Partials 18738 18738
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package.xmlneeds a dependency forlibopencv-dev(see https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/6275268080/job/17042494020?pr=33)Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.