Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add workaround for tf2 update #5127

Merged
merged 2 commits into from
Sep 26, 2023
Merged

chore: add workaround for tf2 update #5127

merged 2 commits into from
Sep 26, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Sep 26, 2023

Description

add workaround for tf2 update

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21
chore: add workaround for tf2 update
0c03ade 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 26, 2023
@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2023
@SakodaShintaro SakodaShintaro mentioned this pull request Sep 26, 2023
Closed
3 tasks
tkimura4
tkimura4 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 enabled auto-merge (squash) September 26, 2023 02:53
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 26, 2023
@wep21
add more compile definition
90986aa 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 force-pushed the workaround-for-tf2-update branch from e9095d8 to 90986aa Compare September 26, 2023 05:11
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (46f871f) 14.97% compared to head (90986aa) 14.96%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5127      +/-   ##
==========================================
- Coverage   14.97%   14.96%   -0.01%     
==========================================
  Files        1613     1613              
  Lines      111984   112158     +174     
  Branches    34692    34823     +131     
==========================================
+ Hits        16764    16781      +17     
- Misses      76485    76575      +90     
- Partials    18735    18802      +67
Flag Coverage Δ *Carryforward flag
differential 16.28% <ø> (?)
total 14.97% <ø> (ø) Carriedforward from 46f871f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...clude/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wep21 wep21 disabled auto-merge September 26, 2023 10:25
@wep21 wep21 merged commit 19ab508 into main Sep 26, 2023
@wep21 wep21 deleted the workaround-for-tf2-update branch September 26, 2023 10:27
wep21 added a commit that referenced this pull request Sep 26, 2023
@wep21
Revert "chore: add workaround for tf2 update (#5127)"
aae172b 
This reverts commit 19ab508.
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 26, 2023
@wep21 @kyoichi-sugahara
chore: add workaround for tf2 update (autowarefoundation#5127)
ca52a43
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 26, 2023
Merged
zulfaqar-azmi-t4 added a commit that referenced this pull request Sep 27, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
5715e44 
…anes (#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
@wep21 @tkimura4
chore: add workaround for tf2 update (autowarefoundation#5127)
15d3a88
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
@wep21 @tkimura4
chore: add workaround for tf2 update (autowarefoundation#5127)
928a1b3
zhiwango pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
@wep21 @zhiwango
chore: add workaround for tf2 update (autowarefoundation#5127)
5346555
@zhiwango zhiwango mentioned this pull request Sep 28, 2023
Merged
kazuki527 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
@wep21 @kazuki527
chore: add workaround for tf2 update (autowarefoundation#5127)
489bb39
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
@zhiwango @wep21
fix(autoware_auto_tf2): remove duplicated function in tf2_geometry_msg (
abe7800 
#886)

chore: add workaround for tf2 update (autowarefoundation#5127)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Sep 28, 2023
@wep21 @maxime-clem
chore: add workaround for tf2 update (autowarefoundation#5127)
0604590
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
@wep21 @soblin
chore: add workaround for tf2 update (autowarefoundation#5127)
51b4b52
zulfaqar-azmi-t4 added a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Sep 29, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
fca6069 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 2, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
2aca75e 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kazuki527 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 2, 2023
@zhiwango @kazuki527
fix(autoware_auto_tf2): remove duplicated function in tf2_geometry_msg (
e856606 
#886)

chore: add workaround for tf2 update (autowarefoundation#5127)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
# Conflicts:
#	planning/behavior_path_planner/CMakeLists.txt
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Oct 2, 2023
@zhiwango @wep21 @maxime-clem
fix(autoware_auto_tf2): remove duplicated function in tf2_geometry_msg (
aa571f6 
tier4#886)

chore: add workaround for tf2 update (autowarefoundation#5127)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
kazuki527 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 2, 2023
@zhiwango @kazuki527
fix(autoware_auto_tf2): remove duplicated function in tf2_geometry_msg (
c479cb1 
#886)

chore: add workaround for tf2 update (autowarefoundation#5127)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
# Conflicts:
#	planning/behavior_path_planner/CMakeLists.txt
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
433f426 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 4, 2023
@wep21 @satoshi-ota
chore: add workaround for tf2 update (autowarefoundation#5127)
d4b407e
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
5f20688 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
@zulfaqar-azmi-t4 @wep21
@kyoichi-sugahara @t4-x2
feat(behavior_path_planner): lane change collided polygon intersect l…
1d67bb3 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 6, 2023
@zulfaqar-azmi-t4 @wep21 @kyoichi-sugahara
feat(behavior_path_planner): lane change collided polygon intersect l…
085420b 
…anes (autowarefoundation#5135)

* feat(behavior_path_planner): lane change collided polygon intersect lanes

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use wrapper instead of std::optional

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange code

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Revert "chore: add workaround for tf2 update (autowarefoundation#5127)"

This reverts commit 19ab508.

* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

* revet change for local build

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 10, 2023
@wep21 @tkimura4
chore: add workaround for tf2 update (autowarefoundation#5127)
758c701 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
kazuki527 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2023
@zhiwango @wep21 @kazuki527
fix(autoware_auto_tf2): remove duplicated function in tf2_geometry_msg (
b7c482b 
#886)

chore: add workaround for tf2 update (autowarefoundation#5127)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Oct 22, 2023
@wep21 @TomohitoAndo
chore: add workaround for tf2 update (autowarefoundation#5127)
7b8b201
@TomohitoAndo TomohitoAndo mentioned this pull request Oct 22, 2023
Merged
4 tasks
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Oct 22, 2023
@TomohitoAndo @wep21
chore: add workaround for tf2 update (autowarefoundation#5127) (#970)
1f33642 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
TakuIwasaki pushed a commit to TakuIwasaki/autoware.universe that referenced this pull request Dec 5, 2023
@wep21
chore: add workaround for tf2 update (autowarefoundation#5127)
a324625
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Dec 5, 2023
@wep21 @TomohitoAndo
chore: add workaround for tf2 update (autowarefoundation#5127)
81add9e
@TomohitoAndo TomohitoAndo mentioned this pull request Dec 5, 2023
Merged
4 tasks
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Dec 5, 2023
@TomohitoAndo @wep21
chore: add workaround for tf2 update (autowarefoundation#5127) (#1055)
6bf509a 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2024
@wep21 @tkimura4
chore: add workaround for tf2 update (autowarefoundation#5127)
2f62952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkimura4 tkimura4 tkimura4 approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@rej55 rej55 Awaiting requested review from rej55

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @tkimura4