Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pose_twist_estimator): automatically initialize pose only with gnss #5115

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Sep 25, 2023

Description

automatic_pose_initializer should be executed only when gnss_enabled is true.
Otherwise, pose_initializer continuously says "GNSS is not supported"
Note that this PR does not affect any system behavior, but if you set gnss_enabled:=false manually, it helps you a lot.

Tests performed

CI

Effects on system behavior

No effect.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Sep 25, 2023
@shmpwk shmpwk marked this pull request as ready for review September 25, 2023 13:45
@shmpwk
Copy link
Contributor Author

shmpwk commented Sep 25, 2023

One problem of this PR is those who see this pose_twist_estimator launch code for the first time may confuse that why there is such <group if="$(var gnss_enabled)"> even though gnss_enabled is already fixed value.

Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that when gnss_enabled:=false, the automatic_pose_initializer node does not start, and there is no output saying "GNSS is not supported."

@YamatoAndo
Copy link
Contributor

@isamu-takagi FYI

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 28, 2023
@YamatoAndo YamatoAndo enabled auto-merge (squash) September 28, 2023 07:50
@YamatoAndo YamatoAndo merged commit 7e9b4de into main Sep 28, 2023
@YamatoAndo YamatoAndo deleted the shmpwk-patch-3 branch September 28, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants