feat(perception_launch): add data_path arg to perception launch #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
lexavtanke
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:launch
miursh
added
the
component:perception
esteve
added
the
run:build-and-test-differential
38 tasks
github-actions
bot
removed
the
component:perception
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
+ Coverage 14.85% 14.96% +0.11%
==========================================
Files 1627 1602 -25
Lines 112674 111124 -1550
Branches 34814 34368 -446
==========================================
- Hits 16739 16634 -105
+ Misses 77171 75869 -1302
+ Partials 18764 18621 -143
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
…warefoundation#5069) * feat(perception_launch): add var data_path to perception.launch Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> * feat(perception_launch): update default center_point_model_path Signed-off-by: Alexey Panferov <lexavtanke@gmail.com> --------- Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
7 tasks
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in issue models now are stored in autoware_data folder. To access to model packages should receive data_path argument from autoware.launch which is introduced in the PR.
This PR adds data_path argument to perception launch and updates default model paths accordingly.
Tests performed
Both logging and planning simulators can start and work.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.