feat(rviz_plugin): add target object type display #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
github-actions
bot
added
type:documentation
|
@satoshi-ota Would you review this PR? |
TakaHoribe
added
the
run:build-and-test-differential
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4855 +/- ##
==========================================
- Coverage 15.12% 15.10% -0.02%
==========================================
Files 1574 1575 +1
Lines 108430 108511 +81
Branches 33315 33315
==========================================
Hits 16395 16395
- Misses 74159 74240 +81
Partials 17876 17876
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
reviewed
Sep 3, 2023
common/tier4_target_object_type_rviz_plugin/src/target_object_type_panel.cpp
Outdated
Show resolved
Hide resolved
satoshi-ota
reviewed
Sep 3, 2023
common/tier4_target_object_type_rviz_plugin/src/target_object_type_panel.hpp
Outdated
Show resolved
Hide resolved
satoshi-ota
approved these changes
Sep 3, 2023
…type_panel.cpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…type_panel.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a display to confirm which modules are using which types of the dynamic object.
Related links
None
Tests performed
Run it with Psim.
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.