chore(build): remove tier4_autoware_utils.hpp evaluator/ simulator/ #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
soblin
changed the title
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
build-fast2/component/evaluator-simulator/remove-tier4_autoware_utils_hpp
branch
from
28d1719 to
10d1f8c
Compare
github-actions
bot
removed
component:planning
soblin
requested review from
TakaHoribe,
tkimura4,
yukkysaito,
kyoichi-sugahara,
maxime-clem,
djargot,
kminoda,
rej55,
satoshi-ota,
shmpwk and
takayuki5168
as code owners
soblin
added
the
run:build-and-test-differential
takayuki5168
approved these changes
Sep 1, 2023
maxime-clem
approved these changes
Sep 1, 2023
|
WalkthroughThe changes involve removing the inclusion of Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (10)
- evaluator/kinematic_evaluator/src/metrics/kinematic_metrics.cpp (1)
- evaluator/localization_evaluator/src/metrics/localization_metrics.cpp (1)
- evaluator/planning_evaluator/src/metrics/deviation_metrics.cpp (1)
- evaluator/planning_evaluator/src/metrics/metrics_utils.cpp (1)
- evaluator/planning_evaluator/src/metrics/obstacle_metrics.cpp (1)
- evaluator/planning_evaluator/src/metrics/stability_metrics.cpp (1)
- evaluator/planning_evaluator/src/metrics/trajectory_metrics.cpp (1)
- evaluator/planning_evaluator/src/metrics_calculator.cpp (1)
- simulator/dummy_perception_publisher/src/node.cpp (1)
- simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp (1)
Files skipped from review due to trivial changes (5)
- evaluator/kinematic_evaluator/src/metrics/kinematic_metrics.cpp
- evaluator/localization_evaluator/src/metrics/localization_metrics.cpp
- evaluator/planning_evaluator/src/metrics/deviation_metrics.cpp
- evaluator/planning_evaluator/src/metrics/obstacle_metrics.cpp
- evaluator/planning_evaluator/src/metrics/trajectory_metrics.cpp
Review comments generated (6)
- Review: 2
- LGTM: 4
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| @@ -14,13 +14,12 @@ | |||
|
|
|||
| #include "planning_evaluator/metrics_calculator.hpp" | |||
|
|
|||
| #include "motion_utils/motion_utils.hpp" | |||
| #include "motion_utils/trajectory/trajectory.hpp" | |||
There was a problem hiding this comment.
The inclusion of the motion_utils/trajectory/trajectory.hpp header file seems to be missing in the new code. Please ensure that it is included.
+ #include "motion_utils/trajectory/trajectory.hpp"| #include "planning_evaluator/metrics/deviation_metrics.hpp" | ||
| #include "planning_evaluator/metrics/obstacle_metrics.hpp" | ||
| #include "planning_evaluator/metrics/stability_metrics.hpp" | ||
| #include "planning_evaluator/metrics/trajectory_metrics.hpp" | ||
| #include "tier4_autoware_utils/tier4_autoware_utils.hpp" | ||
|
|
||
| #include "tier4_autoware_utils/geometry/geometry.hpp" |
There was a problem hiding this comment.
The inclusion of the tier4_autoware_utils/geometry/geometry.hpp header file seems to be missing in the new code. Please ensure that it is included.
+ #include "tier4_autoware_utils/geometry/geometry.hpp"
soblin
removed
the
run:build-and-test-differential
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added
the
run:build-and-test-differential
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4839 +/- ##
=======================================
Coverage 15.12% 15.12%
=======================================
Files 1573 1573
Lines 108415 108415
Branches 33306 33306
=======================================
+ Hits 16395 16396 +1
Misses 74148 74148
+ Partials 17872 17871 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@yukkysaito @tkimura4 @TakaHoribe Can you approve this PR ? |
TakaHoribe
approved these changes
Sep 2, 2023
soblin
deleted the
build-fast2/component/evaluator-simulator/remove-tier4_autoware_utils_hpp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4821
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.
Summary by CodeRabbit
Release Notes:
tier4_autoware_utils/tier4_autoware_utils.hppheader file and replaced it with specific headers in multiple files related to kinematic, localization, planning, and metrics calculations. This change improves modularity and reduces unnecessary dependencies.tier4_autoware_utils/tier4_autoware_utils.hppwith appropriate headers in several files, ensuring correct functionality and compatibility with thetier4_autoware_utilslibrary.