Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(trajectory_follower_node): add missing parameter description #476

Merged
merged 3 commits into from
Mar 22, 2022
Merged

docs(trajectory_follower_node): add missing parameter description #476

merged 3 commits into from
Mar 22, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 3, 2022 •
edited
Loading

Related Issue(required)

Some parameters are not described in the README.

Description(required)

Add description for missing parameters.

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@TakaHoribe
update mpc doc
4324cfd 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe
apply format
3a8d118 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from rej55 and tkimura4 March 3, 2022 12:06
@TakaHoribe TakaHoribe changed the title Docs/update mpc doc docs(trajectory_follower_node): add missing parameter description Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #476 (c2c25ab) into main (14afa55) will increase coverage by 24.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #476       +/-   ##
===========================================
+ Coverage   10.97%   35.34%   +24.37%     
===========================================
  Files         704        7      -697     
  Lines       49562     1372    -48190     
  Branches     6647      850     -5797     
===========================================
- Hits         5440      485     -4955     
+ Misses      39760      161    -39599     
+ Partials     4362      726     -3636
Impacted Files Coverage Δ
...clude/emergency_handler/emergency_handler_core.hpp
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp
map/lanelet2_extension/src/sample_code.cpp
...intcloud_map_loader/pointcloud_map_loader_node.cpp
...include/tier4_autoware_utils/geometry/geometry.hpp
...ensing/gnss_poser/include/gnss_poser/gnss_stat.hpp
...ation_map_loader/src/elevation_map_loader_node.cpp
...ulator/vehicle_model/sim_model_ideal_steer_acc.cpp
...4_vehicle_rviz_plugin/src/tools/steering_angle.cpp
...y_smoother/src/smoother/jerk_filtered_smoother.cpp
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14afa55...c2c25ab. Read the comment docs.

taikitanaka3 added a commit to taikitanaka3/autoware.universe that referenced this pull request Mar 3, 2022
@tkimura4 @mitsudome-r
@obi-t4 @yamacir-kit @kenji-miyake @k0suke-murakami @wep21 @rej55 @TakaHoribe @taikitanaka3 @yukkysaito @hosokawa-ikuto @isamu-takagi @kmiya @KeisukeShima @yk-fujii @s-azumi @h-ohta @yabuta @satoshi-ota @1222-takeshi @kyoichi-sugahara @pre-commit-ci
feat: add autoware_launch package (autowarefoundation#175)
2494573 
* release v0.4.0

* pointcloud_map_path form autoware_launch as optional (autowarefoundation#45)

* pointcloud_map_path form autoware_launch as optional

* add lanelet2_map_path

* use map_file argments under map_path

* Fix unnecessary "default" tag to "value"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add some dependencies (autowarefoundation#54)

* Add some scenario-simulation specifiec parameters as arguments (autowarefoundation#57)

* Add some scenario-simulation specifiec parameters as arguments

* Update arg to pass 'initial_engage_state' to simple_planning_simulator

* Add new optional argument 'rviz_args'

* Rename some roslaunch arguments

* Remove unneeded arguments

* Fix typo (autowarefoundation#63)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add obstacle avoid param (autowarefoundation#62)

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Launch vehicle description in logging simulator (autowarefoundation#67)

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* add autoware api launcher (autowarefoundation#64)

* add blocked by obstacle (autowarefoundation#68)

* Fix turn signal topic name (autowarefoundation#75)

* Revert "Fix turn signal topic name (autowarefoundation#75)" (autowarefoundation#76)

This reverts commit f384b9f7b2e59b7f048926e7eb0fe7c936f5cd3b.

* Fix namespace in autoware.rviz (autowarefoundation#78)

* Fix/turn signal topic name (autowarefoundation#77)

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 1e33e7e3f3e839bcdf623f9e3b4b6a14dd4ec35a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Ros2 port autoware launch (autowarefoundation#35)

* [autoware_launch] port CMakelists.txt and remove COLCON_IGNORE

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_launch] fix planning_simulator.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_launch] add rviz config

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_launch] first port of autoware_launch

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* lanuch rviz with config file

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* modify launch file for making psim work

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* add vehicle model in launch

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* change from vehicle_model to vehicle_param_file

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* [autoware_launch] add autoware_web_controller and system launch

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add rosbrdige_suite to build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Update rviz

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* update autoware.rviz

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove autoware_ros2.rviz

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

Co-authored-by: kosuke murakami <kosuke.murakami@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update rviz config for vehicle rviz plugins (autowarefoundation#41)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 fix packages (autowarefoundation#64)

* add vehicle_param_file to simple planning simulator

* add vehicle_param_file to lane change planner

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 v0.8.0 autoware launch (autowarefoundation#58)

* [autoware_launch] ros2-porting: v0.5.0 to v0.8.0

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Cleanup autoware and logging simulator launch

* Add .xml extention

* Fix missing arguments

* Fix tag

* Fix web controller launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update rviz

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_launch] Fix yaml name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_launch] Cleanup dependencies

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_launch]: Fix missing arguments (autowarefoundation#66)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Ros2 update v0.9.0 (autowarefoundation#67)

* Add pose history into rviz config

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add blocked by obstacle option (autowarefoundation#164)

* fix tab name (autowarefoundation#166)

* disenable ndt visualization (autowarefoundation#169)

* disenable ndt visualization

* change alpha

* dont visualize position covariance

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change global frame to map (autowarefoundation#171)

* add param (autowarefoundation#156)

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* temporary disable steering angle plugin to avoid RVIZ2 to crash (autowarefoundation#76)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix rviz settings (autowarefoundation#77)

* Points -> Squares

* disable road_lanelets

* visualize path of dynamic object

* fix durability policy of route_marker

* fix topic name

* fix topic name of check point

* fix some options about object

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update package.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Fix typo in rviz config (autowarefoundation#80)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fixed typo and added AW_ROS2_USE_SIM_TIME setting (autowarefoundation#81)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* Fix point size in rviz (autowarefoundation#84)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Ros2 fix topic name part1 (autowarefoundation#83)

* Fix topic name for behavior_velocity_planner

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of lane_change_planner

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of freespace_planner

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name for freespace_planner

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix various typos in launch files (autowarefoundation#97)

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync public repo (autowarefoundation#185)

* add tier4 usbcam (autowarefoundation#104)

* add tier4 usbcam

* change version

* tier4/ros2

* Ros2 vehicle info param server (autowarefoundation#96)

* add vehicle info param server

* delete vehicle param file

Co-authored-by: taikitanaka <ttatcoder@outlook.jp>

* Ros2 fix topic name part2 (autowarefoundation#89)

* Fix topic name for traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name for traffic_light_visualization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name for traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add vehicle info param server into logging simulator (autowarefoundation#194)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add control composed launch (autowarefoundation#201)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add param for psim v2 (autowarefoundation#197)

* add param for psim v2

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* Update to pass var 'scenario_simulation' to dummy_perception_publisher

* Update dummy_perception_publisher's arg-name

Co-authored-by: yamacir-kit <httperror@404-notfound.jp>

* Feature/porting v0.9.1 master (autowarefoundation#202)

* add simulation arg (autowarefoundation#174)

* add simulation arg

* add comment

* change arg name

* add parameter use_empty_dynamic_object_publisher into perception.launch (autowarefoundation#176)

Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>

Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>

* Add vehicle info launch for setting vehicle info param (autowarefoundation#199)

* Add vehicle info launch for setting vehicle info param

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add comment for global parameters section

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix year and apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ready vehicle info param

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove vehicle info param server from logging simulator (autowarefoundation#211)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add map.launch.py (autowarefoundation#212)

* Add map.launch.py

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update map.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Rename parameter for lanelet2 map path

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Exclude dummy_perception_publisher.launch.xml if is scenario_simulation (autowarefoundation#230)

* Remove clock publisher (autowarefoundation#217)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fixup for autowarefoundation#217 (autowarefoundation#254)

* Fixup for autowarefoundation#217

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add global_params.launch.py (autowarefoundation#260)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add time panel (autowarefoundation#233)

* Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader (autowarefoundation#282)

* Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add exec_depend

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add descriptions for autoware_launch autowarefoundation#329

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Add autoware api (autowarefoundation#376)

* Add external api adaptor (autowarefoundation#267)

* Add external api adaptor

* Add api adaptor to logging simulator

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add engage status output

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add internal api adaptor (autowarefoundation#273)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add map hash generator (autowarefoundation#319)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add autoware api launch (autowarefoundation#326)

* Add autoware api launch

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Apply autoware api launch

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add deprecated comment

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove unused parameter (autowarefoundation#325)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add api parameter (autowarefoundation#341)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add start request API (autowarefoundation#321)

* Add use start request option

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Feature external cmd selector heartbeat (autowarefoundation#356)

* Rename external command topic

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Modify command topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Rename remote_cmd_converter

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove gate mode from external command

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix latest external command name (autowarefoundation#361)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix merge conflict

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* change external traffic light topic name in behavior velocity planner (autowarefoundation#310)

* fix topic

* change internal topic name

Co-authored-by: yabuta <makoto.yabuta@tier4.jp>

* Feature/add virtual traffic light planner (autowarefoundation#317)

* Move autoware api launch files (autowarefoundation#387)

* Fix misspell in rviz config (autowarefoundation#392)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update rviz config (autowarefoundation#399)

* update rviz config

* update config

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add polar grid into rviz config (autowarefoundation#458)

* Add simulator_launch package (autowarefoundation#459)

* Add simulator_launch package

* add argument

* fix depend order

* add argument

* move dummy_perception_publisher

* add arg for dummy_perception_publisher

* Update simulator_launch/launch/simulator.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* add steering angle (autowarefoundation#476)

* Move simple_planning_simulator to simulator_launch (autowarefoundation#462)

* move simple_planning_simulator

* add simulation arg to logging_simulator.launch

* delete unused argument

* add arguments for logging simulation

* change default value

* update README

* add default value to simulator arg

* restore vehicle_simulation arg

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* hide traffic light id by default (autowarefoundation#286)

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Feature/porting behavior path planner (autowarefoundation#300)

* modify behavior_planning launch for behavior_path_planner with lane_c… (autowarefoundation#239)

* modify behavior_planning launch for behavior_path_planner with lane_change_only config

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove avoidance & side_shift related code

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix launcher and add config files and change obstacle avoid param

* Add new line

* Fix visualization and remove multiple args

* Enable auto approve path change

Co-authored-by: rej55 <rej55.g@gmail.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add param in behavior_path_planner (autowarefoundation#255)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix param (autowarefoundation#251)

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: rej55 <rej55.g@gmail.com>

* update rviz config & planner params (autowarefoundation#305)

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Feature/porting occlusion spot (autowarefoundation#309)

* add occulusion_spot marker (autowarefoundation#266)

* add blindspot marker

* to occlusion spot slow down

* remove debug info from marker (autowarefoundation#287)

* remove debug info from marker

* remove debug arrow

* fix format

* update behavior launch

* apply pep8

* fix format

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* Feature/porting camera lidar fusion (autowarefoundation#316)

* Feature/camera lidar fusion (autowarefoundation#248)

* change camera lidar fusion node

* change default mode of object recognition

* change spilit range parameter from 10 to 30 (autowarefoundation#272)

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* add underscore to marker namespace (autowarefoundation#323)

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Feature/hide verbose marker (autowarefoundation#322)

* tmp : enable slow down

* hide verbose markers

* Revert "tmp : enable slow down"

This reverts commit 5ad32c5903866d9cf946cc47b0b35cefa359d502.

* update rviz tool bar

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* update rviz config ( add shoulder road lanelets ) (autowarefoundation#420)

* update rviz config

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Fix for pre-commit (437)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Auto/fix launch (autowarefoundation#110)

* fix namespace

* remove dynamic_object_visualization

* fix rviz

* change topic name for rviz plugin (autowarefoundation#114)

* Auto/launcher ground segmentation (autowarefoundation#117)

* add base line launch

* add ground_segmentation launcher

* run pre-commit

* clean up

* fix coding style

* fix topic name

* fix yaml params

* fix loader name

* rename components

* improve implementation

* Sync .auto branch with the latest branch in internal repository (autowarefoundation#120)

* Disbale intersection polygon marker (autowarefoundation#483)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area

Feature/no stopping area

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix turn signal to indicators (autowarefoundation#123)

* fix no ground points topic name (autowarefoundation#125)

* support x1 perception config (autowarefoundation#129)

* support x1 perception config

* remove product config

* update launch.py

* maintain some filters params in yaml file

* add function to create elevation map pipeline

* add param to yaml

* fix/rviz perception config (autowarefoundation#138)

* fix/rename segmentation namespace (autowarefoundation#139)

* fix namespace: rviz config

* fix namespace: planning stack

* rename segmentatino directory

* fix namespace: perception stack

* fix/add arg in order to disable dummy_perception_publisher from command line (autowarefoundation#144)

* change topic name for predicted trajectory (autowarefoundation#145)

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* add vehicle_info_param_file

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

* fix launch files and remove api launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

* add initial pose relay

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Yamasaki Tatsuya <httperror@404-notfound.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tkimura4
tkimura4 previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rej55
rej55 reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TakaHoribe
Could you fix typo as well? (Quadradic -> Quadratic)

autoware.universe/control/trajectory_follower_nodes/design/lateral_controller-design.md

Line 20 in 3a8d118

The optimization of the control command is formulated as a Quadradic Program (QP).

@wep21
Copy link
Contributor

wep21 commented Mar 22, 2022

@TakaHoribe ping

@TakaHoribe
fix typo
c2c25ab 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe
Copy link
Contributor Author

@wep21 fixed!

@TakaHoribe TakaHoribe requested a review from wep21 March 22, 2022 08:49
@wep21 wep21 merged commit 3092192 into autowarefoundation:main Mar 22, 2022
@wep21 wep21 deleted the docs/update-mpc-doc branch March 22, 2022 12:34
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 23, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@TakaHoribe @boyali
docs(trajectory_follower_node): add missing parameter description (ti…
a0ef43c 
…er4#476)

* update mpc doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@TakaHoribe @boyali
docs(trajectory_follower_node): add missing parameter description (ti…
2647d00 
…er4#476)

* update mpc doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
@yukkysaito
add steering angle (autowarefoundation#476)
59ce97a
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@TakaHoribe @boyali
docs(trajectory_follower_node): add missing parameter description (ti…
beff1f0 
…er4#476)

* update mpc doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
@takayuki5168
feat(obstacle_avoidance_planner): fix can be applied to the first tra…
1d712d0 
…jectory point (#476)

* update param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
@satoshi-ota
feat(avoidance): enable avoidance cancel (autowarefoundation#476)
1bd4808 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
@TomohitoAndo
chore: update hash of vehicle2infrastructure (autowarefoundation#476)
55052b1 
* chore: update hash of vehicle2infrastructure

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* chore: remove transport drivers from repos

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
@h-ohta
fix(system_monitor): fix build error in Humble (autowarefoundation#476)
79d24bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 left review comments

@wep21 wep21 wep21 approved these changes

@tkimura4 tkimura4 tkimura4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TakaHoribe @wep21 @rej55 @tkimura4