chore(planning_debug_tools): enable to set max velocity by arg in trajectory_visualizer.py #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jectory_visualizer.py Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
github-actions
bot
added
the
component:planning
TakaHoribe
approved these changes
Aug 26, 2023
taikitanaka3
approved these changes
Sep 1, 2023
TakaHoribe
added
the
run:build-and-test-differential
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4748 +/- ##
=======================================
Coverage 15.08% 15.08%
=======================================
Files 1563 1563
Lines 107896 107894 -2
Branches 33111 33111
=======================================
Hits 16272 16272
+ Misses 73868 73866 -2
Partials 17756 17756
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify to allow setting the maximum speed from the command line, as the fluctuation of the maximum speed on a per-frame can lead to increased difficulty in visibility.
Tests performed
ros2 run planning_debug_tools trajectory_visualizer.py -v 10
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.