Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): modify ego polygon calculation #4694

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 22, 2023

Description

Fixed the error of ego polygon calculation for collision detection

Related links

TierIV COMPANY INTERNAL LINK

Tests performed

Psim

Before PR

The red polygon is generated on the wrong place.

image

After PR

The red polygon is generated around ego vehicle.

image

evaluator

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 22, 2023
@soblin soblin marked this pull request as ready for review August 22, 2023 04:50
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/intersection/find-ego-polygon-from-entire-lanelets2 branch from c2b511d to 7c17433 Compare August 22, 2023 05:47
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@soblin soblin enabled auto-merge (squash) August 23, 2023 00:17
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (9b1e4e3) 14.88% compared to head (7c17433) 14.88%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4694      +/-   ##
==========================================
- Coverage   14.88%   14.88%   -0.01%     
==========================================
  Files        1549     1549              
  Lines      106958   106967       +9     
  Branches    32791    32793       +2     
==========================================
  Hits        15925    15925              
- Misses      73639    73648       +9     
  Partials    17394    17394              
Flag Coverage Δ *Carryforward flag
differential 7.07% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 9b1e4e3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit b56a7fb into autowarefoundation:main Aug 23, 2023
@soblin soblin deleted the fix/intersection/find-ego-polygon-from-entire-lanelets2 branch August 23, 2023 01:00
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…#4694)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 23, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…#4694)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
fix(intersection): modify ego polygon calculation (autowarefoundation#4694)
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…#4694)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants