Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(obstacle_velocity_limiter): correct spelling for cspell #4687

Conversation

maxime-clem
Copy link
Contributor

Description

Correct spelling in the obstacle_velocity_limiter package.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 22, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem changed the title #4682 chore(obstacle_velocity_limiter): correct spelling for cspell #4682 fix(obstacle_velocity_limiter): correct spelling for cspell Aug 22, 2023
@maxime-clem maxime-clem changed the title #4682 fix(obstacle_velocity_limiter): correct spelling for cspell chore(obstacle_velocity_limiter): correct spelling for cspell Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 53.33% and project coverage change: -0.01% ⚠️

Comparison is base (489eb05) 14.88% compared to head (5247caf) 14.88%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4687      +/-   ##
==========================================
- Coverage   14.88%   14.88%   -0.01%     
==========================================
  Files        1549     1549              
  Lines      106955   106949       -6     
  Branches    32790    32785       -5     
==========================================
- Hits        15925    15924       -1     
+ Misses      73636    73635       -1     
+ Partials    17394    17390       -4     
Flag Coverage Δ *Carryforward flag
differential 27.66% <53.33%> (?)
total 14.88% <ø> (-0.01%) ⬇️ Carriedforward from 20d2dab

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...limiter/benchmarks/collision_checker_benchmark.cpp 0.00% <ø> (ø)
...r/include/obstacle_velocity_limiter/parameters.hpp 37.20% <0.00%> (ø)
...imiter/include/obstacle_velocity_limiter/types.hpp 100.00% <ø> (ø)
planning/obstacle_velocity_limiter/src/debug.cpp 0.00% <ø> (ø)
...ity_limiter/src/obstacle_velocity_limiter_node.cpp 16.55% <0.00%> (ø)
...obstacle_velocity_limiter/src/pointcloud_utils.cpp 0.00% <ø> (ø)
..._velocity_limiter/test/test_collision_distance.cpp 21.31% <ø> (ø)
..._velocity_limiter/test/test_forward_projection.cpp 40.00% <0.00%> (ø)
.../obstacle_velocity_limiter/test/test_obstacles.cpp 100.00% <ø> (ø)
...elocity_limiter/test/test_occupancy_grid_utils.cpp 36.00% <ø> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem marked this pull request as ready for review August 22, 2023 01:32
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem merged commit 0cf68fe into autowarefoundation:main Aug 22, 2023
@maxime-clem maxime-clem deleted the cspell/obstacle_velocity_limiter branch August 22, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants