-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): more stable dynamic drivable area expansion #4677
Merged
maxime-clem
merged 7 commits into
autowarefoundation:main
from
maxime-clem:feat/behavior_path_planner-stable_dyn_da_expansion_universe
Sep 1, 2023
Merged
feat(behavior_path_planner): more stable dynamic drivable area expansion #4677
maxime-clem
merged 7 commits into
autowarefoundation:main
from
maxime-clem:feat/behavior_path_planner-stable_dyn_da_expansion_universe
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Aug 21, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
feat/behavior_path_planner-stable_dyn_da_expansion_universe
branch
from
August 22, 2023 09:06
87f3030
to
b440649
Compare
4 tasks
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 22, 2023
maxime-clem
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
August 22, 2023 12:08
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
- Coverage 14.88% 14.79% -0.10%
==========================================
Files 1549 1549
Lines 106958 107876 +918
Branches 32791 33435 +644
==========================================
+ Hits 15925 15958 +33
- Misses 73639 74424 +785
- Partials 17394 17494 +100
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 31, 2023
maxime-clem
deleted the
feat/behavior_path_planner-stable_dyn_da_expansion_universe
branch
September 1, 2023 01:43
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 14, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 15, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 25, 2023
…ion (autowarefoundation#4677) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the stability of the drivable area bounds when using the dynamic expansion.
The instability is caused by the path points moving, so this PR adds a resampling of the points at fixed intervals.
Requires the following PR to add the new parameter: autowarefoundation/autoware_launch#522.
Tests performed
Psim and evaluator.
Effects on system behavior
More stable drivable area bounds when using the dynamic expansion.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.