Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_projection_loader): add backward compatibility for local map #4586

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 10, 2023

Description

Add backward compatibility for local map.

When loading the following xml, previous version of map_projection_loader will be in an undefined behavior. In order to address this, I would like to add a backward compatibility for such lanelet as well.

<?xml version="1.0"?>
<osm version="0.6" generator="lanelet2">
  <node id="1" lat="" lon=""/>
</osm>⏎       

Related links

N/A

Tests performed

Please see the added test

Notes for reviewers

N/A

Interface changes

Backward compatibility has been added in map files. No negative effect intended.

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Aug 10, 2023
pre-commit-ci bot and others added 4 commits August 10, 2023 04:23
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 10, 2023
@kminoda kminoda marked this pull request as ready for review August 10, 2023 04:37
@kminoda kminoda marked this pull request as draft August 10, 2023 04:39
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 34.78% and project coverage change: +0.01% 🎉

Comparison is base (8ff2128) 14.82% compared to head (19d7012) 14.83%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4586      +/-   ##
==========================================
+ Coverage   14.82%   14.83%   +0.01%     
==========================================
  Files        1531     1531              
  Lines      105756   105791      +35     
  Branches    32145    32170      +25     
==========================================
+ Hits        15676    15694      +18     
+ Misses      72961    72955       -6     
- Partials    17119    17142      +23     
Flag Coverage Δ *Carryforward flag
differential 37.93% <34.78%> (?)
total 14.80% <ø> (-0.02%) ⬇️ Carriedforward from dc62d00

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...n_loader/test/test_load_info_from_lanelet2_map.cpp 42.42% <34.21%> (-10.91%) ⬇️
...jection_loader/src/load_info_from_lanelet2_map.cpp 37.50% <37.50%> (+7.50%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as ready for review August 10, 2023 04:42
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda and others added 4 commits August 10, 2023 14:51
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda enabled auto-merge (squash) August 10, 2023 06:22
@kminoda kminoda merged commit 60d001e into autowarefoundation:main Aug 10, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…autowarefoundation#4586)

* feat(map_projection_loader): add backward compatibility for local map

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* feat: add dummy typo

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert unnecessary fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* rename test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix comment

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove comment

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kminoda kminoda deleted the feat/map_projection_loader/add_backward_compatibility_for_local branch August 23, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants