-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_projection_loader): add backward compatibility for local map #4586
Merged
kminoda
merged 11 commits into
autowarefoundation:main
from
kminoda:feat/map_projection_loader/add_backward_compatibility_for_local
Aug 10, 2023
Merged
feat(map_projection_loader): add backward compatibility for local map #4586
kminoda
merged 11 commits into
autowarefoundation:main
from
kminoda:feat/map_projection_loader/add_backward_compatibility_for_local
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
github-actions
bot
added
the
component:map
Map creation, storage, and loading. (auto-assigned)
label
Aug 10, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 10, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4586 +/- ##
==========================================
+ Coverage 14.82% 14.83% +0.01%
==========================================
Files 1531 1531
Lines 105756 105791 +35
Branches 32145 32170 +25
==========================================
+ Hits 15676 15694 +18
+ Misses 72961 72955 -6
- Partials 17119 17142 +23
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
commented
Aug 10, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YamatoAndo
approved these changes
Aug 10, 2023
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…autowarefoundation#4586) * feat(map_projection_loader): add backward compatibility for local map Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * feat: add dummy typo Signed-off-by: kminoda <koji.minoda@tier4.jp> * update test Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert unnecessary fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * rename test Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix comment Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove comment Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda
deleted the
feat/map_projection_loader/add_backward_compatibility_for_local
branch
August 23, 2023 00:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:map
Map creation, storage, and loading. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add backward compatibility for local map.
When loading the following xml, previous version of map_projection_loader will be in an undefined behavior. In order to address this, I would like to add a backward compatibility for such lanelet as well.
Related links
N/A
Tests performed
Please see the added test
Notes for reviewers
N/A
Interface changes
Backward compatibility has been added in map files. No negative effect intended.
Effects on system behavior
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.