fix(scnenario_selector): prevent changing scneario when same uuid route is received #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
run:build-and-test-differential
takayuki5168
approved these changes
Aug 8, 2023
…te is received Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
fix/prevent_changing_scnenario
branch
from
ab0e7ea to
9c87223
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
==========================================
- Coverage 14.80% 14.80% -0.01%
==========================================
Files 1527 1527
Lines 105673 105674 +1
Branches 32107 32108 +1
==========================================
- Hits 15649 15648 -1
- Misses 72945 72946 +1
- Partials 17079 17080 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
7 tasks
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2023
…te is received (autowarefoundation#4569) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…te is received (autowarefoundation#4569) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…te is received (autowarefoundation#4569) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…te is received (autowarefoundation#4569) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent changing scneario when same uuid route is received
e.g.
If the goal is modified during a freespace pull over, it is rerouted. If ego is already out of lane at this time, the scenario may change unintentionally.
Related links
Tests performed
psim
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.