fix(start_planner): remove shift pull out enough distance check #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
kosuke55
added
the
run:build-and-test-differential
github-actions
bot
added
component:planning
7 tasks
3 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
=========================================
Coverage 14.93% 14.93%
=========================================
Files 1515 1515
Lines 104545 106518 +1973
Branches 31777 33235 +1458
=========================================
+ Hits 15613 15910 +297
- Misses 71895 73312 +1417
- Partials 17037 17296 +259
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 1, 2023
…warefoundation#4422) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2023
…warefoundation#4422) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…warefoundation#4422) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4418 surfaces potential bugs in loop route path generation.
this is because the extended road lanes has previous lanes of current lanes, and the goal and current pose arc corrdinates are caluculated wrongly. This lead to wrong hasEnoughDistance judgement.
In this PR remove the hasEnoghDistance because currently the distance is calculated validly like #4005
Related links
#4418
Tests performed
tier4 internal scenario test 1580/1588
base:
1577/1588(2023/07/30)
psim
teir4 internal scenario test
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.