Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): start with acceleration #4005

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 19, 2023

Description

start_planner generate path with acceleration.

Related links

Tests performed

psim

tier4 internal scenario test

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2023
@kosuke55
Copy link
Contributor Author

clean up after test

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/acc_pull_out branch from fa214fc to 7218731 Compare June 19, 2023 08:45
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (7354014) 14.41% compared to head (7218731) 14.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4005      +/-   ##
==========================================
- Coverage   14.41%   14.39%   -0.02%     
==========================================
  Files        1456     1456              
  Lines      102763   102908     +145     
  Branches    29782    29879      +97     
==========================================
+ Hits        14814    14816       +2     
- Misses      71767    71905     +138     
- Partials    16182    16187       +5     
Flag Coverage Δ *Carryforward flag
differential 12.75% <0.00%> (?)
total 14.41% <ø> (+<0.01%) ⬆️ Carriedforward from 7354014

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/utils/start_planner/start_planner_parameters.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.33% <0.00%> (-0.03%) ⬇️
...planner/src/utils/start_planner/shift_pull_out.cpp 3.03% <0.00%> (-0.42%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 532cad0 into main Jun 19, 2023
@kosuke55 kosuke55 deleted the feat/acc_pull_out branch June 19, 2023 12:53
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants