-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix bad dynamic drivable area expansion at path extremities #4259
fix(behavior_path_planner): fix bad dynamic drivable area expansion at path extremities #4259
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4259 +/- ##
=======================================
Coverage 14.82% 14.82%
=======================================
Files 1531 1531
Lines 105756 105814 +58
Branches 32145 32190 +45
=======================================
+ Hits 15676 15689 +13
- Misses 72961 72984 +23
- Partials 17119 17141 +22
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b46df4d
to
76e475c
Compare
eada8b6
to
b0afaaf
Compare
928522a
to
f02e81f
Compare
f02e81f
to
f43c16a
Compare
I'm in review |
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit 8e48989. Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
6a9193c
to
10cd778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…t path extremities (autowarefoundation#4259) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…t path extremities (autowarefoundation#4259) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…t path extremities (autowarefoundation#4259) (#721) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…t path extremities (autowarefoundation#4259) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
This PR improves the dynamic drivable area expansion, making the bounds look cleaner, especially at the at the start and end of the path.
Tests performed
Psim
Evaluator: https://evaluation.tier4.jp/evaluation/reports/tables/new?project_id=x2_dev&job_id=727d6936-d9ae-5829-98ec-a0f489b09ba9&catalog_id=6888286a-35b1-4121-b322-0c6f0e3d8868&filter=&table_config=date
Effects on system behavior
This should not impact the system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.